Re: [PATCH 00/66] Clean up the TUI

Pedro Alves
2019-06-24T14:23:23Z

On 6/23/19 11:42 PM, Tom Tromey wrote:

> On the other hand, working on the TUI changed my mind about the TUI
> generally. I've become a fan. I think it would be good to improve
> the TUI for users, but to do that I think we first have to improve its
> code.

Ahah, welcome on board. :-)

>
> This series is a start at this. It's already quite long,
> unfortunately, and yet is still incomplete. Still, I think it is
> progress. This series:
>
> * Splits tui_win_info into subclasses, one per window type.
>
> * Adds virtual methods, particularly in an attempt to remove all the
> code that switches based on the type of the window. This is
> important to make it simpler to add new window types.
>
> * Changes tui_gen_win_info into a real base class for tui_win_info.
>
> * Removes the uses of unions from the window class hierarchy.
>
> * Simplifies and C++-ifies various other minor things along the way.
>

Hurray!

As I think you know, I attempted something like this over 7 years ago,
but doing it in C wasn't nearly as nice and I just gave up. Being
a TUI user myself, I was so happy to see this series that I couldn't
resist and started reading it straight away. Thanks so much for
working on this.

Looks like only patches up to #49 made it to the list (and I haven't
received a copy of the missing ones either).

Anyway, I skimmed patches #1-#49, and I sent a few responses
for some very minor things, but overall all of it seems good to me.
Looking forward to see this merged.

> I tested this by trying the various TUI features by hand. However,
> I'm not sure I managed to test them all.

If you have this on a branch, I volunteer to test a bit.

Thanks,
Pedro Alves