Re: [PATCH 08/66] Remove tui_list

Pedro Alves
2019-06-24T16:05:27Z

On 6/24/19 4:11 PM, Ruslan Kabatsayev wrote:
> BTW, if you compile a declaration like "struct
> std::vector<tui_win_info*> source_windows;" with clang++ (with -Wall
> option), you'll get a warning "struct 'vector' was previously declared
> as a class [-Wmismatched-tags]", so it's better to either drop the
> "struct" or change it to "class".

GDB actually disables that warning explicitly, with -Wno-mismatched-tags
(gdb/warning.m4).

The mismatch is only important for MS's Visual Studio, since although
the C++ standard says struct and class are the same, IIRC Visual Studio
mangles struct vs class differently. But, AFAIK, no one ever builds
GDB with Visual Studio. At least, I've not heard of anyone
attempting it, though I guess it might be possible nowadays, with
Visual Studio offering much better standard C++ compliance than it used to.

Thanks,
Pedro Alves