Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Keith Seitz <keiths@redhat.com>
Subject: [committed][gdb/testsuite] Fix inter-cu refs in inlined_subroutine-inheritance.exp
Date: Mon, 24 Jun 2019 10:22:00 -0000	[thread overview]
Message-ID: <20190624102231.GA26718@delia> (raw)

Hi,

When running gdb.dwarf2/inlined_subroutine-inheritance.exp with board
cc-with-dwz, we run into:
...
dwz: inlined_subroutine-inheritance: Couldn't find DIE referenced by \
  DW_AT_abstract_origin
...

The problem is that the DW_AT_abstract_origin attributes refer to DIEs in
other CUs, while the references are encoded using the cu-relative encoding
DW_FORM_ref4.

Fix this by forcing the references to use DW_FORM_ref_addr.

Tested on x86_64-linux.

Tested with commit c24bdb023c "Introduce dwarf2_cu::get_builder" reverted,
and verified that the test-case fails in the same way before and after this
patch.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix inter-cu refs in inlined_subroutine-inheritance.exp

gdb/testsuite/ChangeLog:

2019-06-24  Tom de Vries  <tdevries@suse.de>

	* gdb.dwarf2/inlined_subroutine-inheritance.exp:

---
 gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp b/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp
index 19b859492a..b51063c018 100644
--- a/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp
+++ b/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp
@@ -44,17 +44,17 @@ Dwarf::assemble $asm_file {
 	    {name "<artificial>"}
 	} {
 	    D72f8: subprogram {
-		{abstract_origin :$D272519}
+		{abstract_origin %$D272519}
 		{low_pc 0xb9e20 addr}
 		{high_pc 0x1f5 data4}
 	    } {
 		D736e: inlined_subroutine {
-		    {abstract_origin :$D26b227}
+		    {abstract_origin %$D26b227}
 		    {low_pc 0xb9efc addr}
 		    {high_pc 0xc data4}
 		} {
 		    formal_parameter {
-			{abstract_origin :$D274c42}
+			{abstract_origin %$D274c42}
 		    }
 		}
 	    }


                 reply	other threads:[~2019-06-24 10:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190624102231.GA26718@delia \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox