Re: [PATCH 14/66] Introduce has_locator method

Pedro Alves
2019-06-24T14:13:36Z

On 6/23/19 11:42 PM, Tom Tromey wrote:
> - int has_locator; /* Does locator belongs to this window? */
> + bool has_locator; /* Does locator belongs to this window? */

I'd vote to fix the comment's grammar at the same time.

/me reads rest of series.

I see now that the comment is moved around in the following patch,
though it remains incorrect. Fine with me to leave it as is if
it helps. It's not a big deal. I'm only commenting on that
because I wanted to comment on something else, below.

> /* Execution information window. */
> struct tui_gen_win_info *execution_info;
> int horizontal_offset; /* Used for horizontal scroll. */
> @@ -285,6 +285,12 @@ public:
> /* Clear the pertinent detail in the window. */
> virtual void clear_detail () = 0;
>
> + /* Return true if this window has a locator. */

Should this "a locator" be "the locator", or ...

> + virtual bool has_locator () const
> + {
> + return false;
> + }

> void clear_detail () override;
> +
> + /* Return true if this window has the locator. */
> + bool has_locator () const override;

... should this here be "a locator"?

Thanks,
Pedro Alves