Re: [PATCH 08/66] Remove tui_list

Ruslan Kabatsayev
2019-06-24T15:12:02Z

Hello,

On Mon, 24 Jun 2019 at 17:12, Pedro Alves <palves@redhat.com> wrote:
>
> On 6/23/19 11:42 PM, Tom Tromey wrote:
> > -static struct tui_list source_windows = {src_win_list, 0};
> > +static struct std::vector<tui_win_info *> source_windows;
>
> I usually prefer to drop "struct", but I can live with it.
>
> However, I have to say that "struct std::vector" looks weird. :-)

BTW, if you compile a declaration like "struct
std::vector<tui_win_info*> source_windows;" with clang++ (with -Wall
option), you'll get a warning "struct 'vector' was previously declared
as a class [-Wmismatched-tags]", so it's better to either drop the
"struct" or change it to "class".

>
> (There are other instances in the patch.)
>
> Thanks,
> Pedro Alves

Regards,
Ruslan