From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48299 invoked by alias); 23 Jun 2019 22:43:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48098 invoked by uid 89); 23 Jun 2019 22:43:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=2056, sole X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Jun 2019 22:43:42 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 6822214189 for ; Sun, 23 Jun 2019 17:43:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fBD3hIMZw2PzOfBD3hXxuI; Sun, 23 Jun 2019 17:43:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pOa0tIUXHUllYewvX0hPO+qiJE/eU8QXdXKsJdPYc0Q=; b=dtDstrnXc6uuMWnoP9hAoM4nrS FNW/H0I4+OjuxVpz95guqDyXu5fH8Au0PytbX2Vbvvn25dWcY5oeSB/7aKXlFuHFooV1ymjxeAhl6 oJjMgwXgUUPOl+jvKQmbKKpO3; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:54396 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hfBD3-000vDQ-7O; Sun, 23 Jun 2019 17:43:41 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 13/66] Remove tui_clear_win_detail Date: Sun, 23 Jun 2019 22:43:00 -0000 Message-Id: <20190623224329.16060-14-tom@tromey.com> In-Reply-To: <20190623224329.16060-1-tom@tromey.com> References: <20190623224329.16060-1-tom@tromey.com> X-SW-Source: 2019-06/txt/msg00466.txt.bz2 An earlier patch changed the context of the sole call to tui_clear_win_detail to make it clear that this can never be called with a NULL window pointer. So, remove tui_clear_win_detail in favor of calling the method directly. gdb/ChangeLog 2019-06-23 Tom Tromey * tui/tui-data.h (tui_clear_win_detail): Don't declare. * tui/tui-data.c (tui_clear_source_windows_detail): Call the clear_detail method directly. (tui_clear_win_detail): Remove. --- gdb/ChangeLog | 7 +++++++ gdb/tui/tui-data.c | 11 +---------- gdb/tui/tui-data.h | 1 - 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c index b3d68df8f3c..b5852bed0bb 100644 --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -159,7 +159,7 @@ void tui_clear_source_windows_detail () { for (tui_win_info *win : tui_source_windows ()) - tui_clear_win_detail (win); + win->clear_detail (); } @@ -205,15 +205,6 @@ tui_data_window::clear_detail () detail.data_display_info.display_regs = FALSE; } -/* Clear the pertinant detail in the windows. */ -void -tui_clear_win_detail (struct tui_win_info *win_info) -{ - if (win_info != NULL) - win_info->clear_detail (); -} - - /* Accessor for the source execution info ptr. */ struct tui_gen_win_info * tui_source_exec_info_win_ptr (void) diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index a4dce4d036b..54cd27c2e46 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -439,7 +439,6 @@ extern struct tui_gen_win_info *tui_disassem_exec_info_win_ptr (void); extern struct std::vector &tui_source_windows (); extern void tui_clear_source_windows (void); extern void tui_clear_source_windows_detail (void); -extern void tui_clear_win_detail (struct tui_win_info *); extern void tui_add_to_source_windows (struct tui_win_info *); extern struct tui_win_info *tui_win_with_focus (void); extern void tui_set_win_with_focus (struct tui_win_info *); -- 2.17.2