From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72980 invoked by alias); 11 Jun 2019 21:49:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72963 invoked by uid 89); 11 Jun 2019 21:49:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Jun 2019 21:49:16 +0000 Received: by mail-wm1-f65.google.com with SMTP id u8so4452719wmm.1 for ; Tue, 11 Jun 2019 14:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qw5eWH/AgBiKo5NRI0PhAwaDd6Y6YFOxZvcmFH2knuo=; b=QNJovP4Hxgy3tMB4xGxQH2QpFnav+Ju2GqNSSEs1dHh7GC760EbTzIirJpPhC4eNHk Ixn5XAcJ0qBRJSGlaPzYCUZFoI8q/fXPHm0FpvlDSdPBVzBSau2VGMng5P0/9VT+2l9m ZNht7Bidz52dXXjUAWQF3A5PuDPaa5iKA3VsIyo4cIfj74ctXJDilfoJz+lfjiGz4llN K88E+EGNbykQE5YRbr331nZ4l/XGb813llJeQoZyPSFFXovQ48qx1d8eBoZ09T3ZfSG4 H2DdKFXz+in/WmdroBD8P+421b0ZvZuDSGdAeucX0w0j0/OUTgqaX5jR73H/NUG9J5oo 5drQ== Return-Path: Received: from localhost (host86-180-62-212.range86-180.btcentralplus.com. [86.180.62.212]) by smtp.gmail.com with ESMTPSA id t6sm15602922wrp.14.2019.06.11.14.49.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 14:49:13 -0700 (PDT) Date: Tue, 11 Jun 2019 21:49:00 -0000 From: Andrew Burgess To: Stafford Horne Cc: GDB patches , GNU Binutils , Andrey Bacherov , Nick Clifton , Richard Henderson , Openrisc Subject: Re: [PATCH v3 11/11] sim/testsuite/or1k: Add tests for unordered compares Message-ID: <20190611214912.GT23204@embecosm.com> References: <20190610204940.3846-1-shorne@gmail.com> <20190610204940.3846-2-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610204940.3846-2-shorne@gmail.com> X-Fortune: Only people with names beginning with 'A' are getting mail this week (a la Microsoft) X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00222.txt.bz2 * Stafford Horne [2019-06-11 05:49:40 +0900]: > Add tests for 32-bit and 64-bit unordered compare instructions. > > sim/testsuite/sim/or1k/ChangeLog: > > yyyy-mm-dd Stafford Horne > > * fpu-unordered.S: New file. > * fpu64a32-unordered.S: New file. This is fine with the nits below fixed. Thanks, Andrew > --- > Changes since v2: > - new patch > > sim/testsuite/sim/or1k/fpu-unordered.S | 97 +++++++++++++++++++ > sim/testsuite/sim/or1k/fpu64a32-unordered.S | 100 ++++++++++++++++++++ > 2 files changed, 197 insertions(+) > create mode 100644 sim/testsuite/sim/or1k/fpu-unordered.S > create mode 100644 sim/testsuite/sim/or1k/fpu64a32-unordered.S > > diff --git a/sim/testsuite/sim/or1k/fpu-unordered.S b/sim/testsuite/sim/or1k/fpu-unordered.S > new file mode 100644 > index 0000000000..bf229878bb > --- /dev/null > +++ b/sim/testsuite/sim/or1k/fpu-unordered.S > @@ -0,0 +1,97 @@ > +/* Tests some basic unordered fpu compare instructions. > + > + Copyright (C) 2017-2019 Free Software Foundation, Inc. Date range should be '2019' only. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +# mach: or1k > +# output: report(0x40490fd0);\n > +# output: report(0x402df84d);\n > +# output: report(0x7fc00000);\n > +# output: \n > +# output: report(0x00000001);\n > +# output: \n > +# output: report(0x00000000);\n > +# output: \n > +# output: report(0x00000001);\n > +# output: \n > +# output: report(0x00000001);\n > +# output: \n > +# output: exit(0)\n > + > +#include "or1k-asm-test-helpers.h" > + > + STANDARD_TEST_ENVIRONMENT > + > + .section .data > + .align 4 > + .type pi, @object > + .size pi, 4 > +anchor: > +pi: > + .float 3.14159 > + > + .type e, @object > + .size e, 4 > +e: > + .float 2.71828 > + > + .section .text > +start_tests: > + PUSH LINK_REGISTER_R9 > + > + /* Test unordered float comparisons. Setting up: > + * r11 pointer to data > + * r12 pi as float > + * r13 e as float > + * r16 nan as float > + */ > + l.ori r11, r0, ha(anchor) > + l.addi r11, r11, lo(anchor) > + l.lwz r12, 0(r11) > + > + l.lwz r13, 4(r11) > + > + /* Make a NaN. */ > + lf.sub.s r16, r13, r13 > + lf.div.s r16, r16, r16 > + > + /* Output to ensure we loaded it correctly. */ > + REPORT_REG_TO_CONSOLE r12 > + REPORT_REG_TO_CONSOLE r13 > + REPORT_REG_TO_CONSOLE r16 > + PRINT_NEWLINE_TO_CONSOLE > + > + lf.sfuge.s r12, r13 > + MOVE_FROM_SPR r2, SPR_SR > + REPORT_BIT_TO_CONSOLE r2, SPR_SR_F > + PRINT_NEWLINE_TO_CONSOLE > + > + lf.sfun.s r12, r13 > + MOVE_FROM_SPR r2, SPR_SR > + REPORT_BIT_TO_CONSOLE r2, SPR_SR_F > + PRINT_NEWLINE_TO_CONSOLE > + > + lf.sfun.s r12, r16 > + MOVE_FROM_SPR r2, SPR_SR > + REPORT_BIT_TO_CONSOLE r2, SPR_SR_F > + PRINT_NEWLINE_TO_CONSOLE > + > + lf.sfueq.s r12, r12 > + MOVE_FROM_SPR r2, SPR_SR > + REPORT_BIT_TO_CONSOLE r2, SPR_SR_F > + PRINT_NEWLINE_TO_CONSOLE > + > + POP LINK_REGISTER_R9 > + RETURN_TO_LINK_REGISTER_R9 > diff --git a/sim/testsuite/sim/or1k/fpu64a32-unordered.S b/sim/testsuite/sim/or1k/fpu64a32-unordered.S > new file mode 100644 > index 0000000000..31c9ee4a33 > --- /dev/null > +++ b/sim/testsuite/sim/or1k/fpu64a32-unordered.S > @@ -0,0 +1,100 @@ > +/* Tests some basic unordered fpu compare instructions. > + > + Copyright (C) 2017-2019 Free Software Foundation, Inc. Date range should be '2019' only. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +# mach: or1k > +# output: report(0x400921f9);\n > +# output: report(0xf01b866e);\n > +# output: report(0x4005bf09);\n > +# output: report(0x95aaf790);\n > +# output: report(0x7ff80000);\n > +# output: report(0x00000000);\n > +# output: \n > +# output: report(0x00000001);\n > +# output: \n > +# output: report(0x00000000);\n > +# output: \n > +# output: report(0x00000001);\n > +# output: \n > +# output: exit(0)\n > + > +#include "or1k-asm-test-helpers.h" > + > + STANDARD_TEST_ENVIRONMENT > + > + .section .data > + .align 4 > + .type pi, @object > + .size pi, 8 > +anchor: > +pi: > + .double 3.14159 > + > + .type e, @object > + .size e, 8 > +e: > + .double 2.71828 > + > + .section .text > +start_tests: > + PUSH LINK_REGISTER_R9 > + > + /* Test unordered double comparisons. Setting up: > + * r11 pointer to data > + * r12,r13 pi as double > + * r14,r15 e as double > + * r16,r17 nan as double > + */ > + l.ori r11, r0, ha(anchor) > + l.addi r11, r11, lo(anchor) > + l.lwz r12, 0(r11) > + l.lwz r13, 4(r11) > + > + l.lwz r14, 8(r11) > + l.lwz r15, 12(r11) > + > + /* Make a NaN. */ > + lf.sub.d r16,r18, r12,r13, r12,r13 > + lf.div.d r16,r18, r16,r18, r16,r18 > + > + /* Output to ensure we loaded it correctly. */ > + REPORT_REG_TO_CONSOLE r12 > + REPORT_REG_TO_CONSOLE r13 > + > + REPORT_REG_TO_CONSOLE r14 > + REPORT_REG_TO_CONSOLE r15 > + > + REPORT_REG_TO_CONSOLE r16 > + REPORT_REG_TO_CONSOLE r18 > + PRINT_NEWLINE_TO_CONSOLE > + > + lf.sfuge.d r12,r13, r14,r15 > + MOVE_FROM_SPR r2, SPR_SR > + REPORT_BIT_TO_CONSOLE r2, SPR_SR_F > + PRINT_NEWLINE_TO_CONSOLE > + > + lf.sfun.d r12,r13, r14,r15 > + MOVE_FROM_SPR r2, SPR_SR > + REPORT_BIT_TO_CONSOLE r2, SPR_SR_F > + PRINT_NEWLINE_TO_CONSOLE > + > + lf.sfun.d r12,r13, r16,r18 > + MOVE_FROM_SPR r2, SPR_SR > + REPORT_BIT_TO_CONSOLE r2, SPR_SR_F > + PRINT_NEWLINE_TO_CONSOLE > + > + POP LINK_REGISTER_R9 > + RETURN_TO_LINK_REGISTER_R9 > -- > 2.21.0 >