From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70557 invoked by alias); 11 Jun 2019 21:48:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70493 invoked by uid 89); 11 Jun 2019 21:48:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.128.68, H*RU:209.85.128.68 X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Jun 2019 21:48:15 +0000 Received: by mail-wm1-f68.google.com with SMTP id s3so4480031wms.2 for ; Tue, 11 Jun 2019 14:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pl4APQp8D9IU0qmCOMoVwd2l33LwiVRoTNgxBiY5s5o=; b=OYCQIQ82vrvpXW47oe41U/94fsjxR+9ZST32RSyYJ36wgIaec6bndj05bR9UPi/sWx pYLCpdV/eTd7X7tu/blzvbI8AQfKFADjSBKEgGSdr19S7oSEmZoa8NSO1GYCrvc3wpx8 k0Q4xsGKhoUQzik0ONx3Rd1FMO7Ki1B1tEQEucPnwmQXvLNWsxw9R5HPYjSOW+eUu27V /YT+ggbP6Po7oFjF7UDEdfmGRbij9MFwHqUNM4yA6NLokU43aduIBTpPZTtNZh0rBqbO 5AMKlHWmozIhSMhm/GojQOiK6yetcHJWhL7Y3y84Hy5tX76iTh9Kl3cqTQaUQ/tFCNbW Manw== Return-Path: Received: from localhost (host86-180-62-212.range86-180.btcentralplus.com. [86.180.62.212]) by smtp.gmail.com with ESMTPSA id f21sm4333584wmb.2.2019.06.11.14.48.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 14:48:12 -0700 (PDT) Date: Tue, 11 Jun 2019 21:48:00 -0000 From: Andrew Burgess To: Stafford Horne Cc: GDB patches , GNU Binutils , Andrey Bacherov , Nick Clifton , Richard Henderson , Openrisc Subject: Re: [PATCH v3 10/11] sim/testsuite/or1k: Add test case for l.adrp instruction Message-ID: <20190611214811.GS23204@embecosm.com> References: <20190610204940.3846-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610204940.3846-1-shorne@gmail.com> X-Fortune: Kleeneness is next to Godelness. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00221.txt.bz2 * Stafford Horne [2019-06-11 05:49:39 +0900]: > This is a simple test to ensure that the l.adrp instruction can be assembled and > simulated correctly. > > sim/testsuite/sim/or1k/ChangeLog: > > yyyy-mm-dd Stafford Horne > > * adrp.S: New file. This is fine with one nit below. Thanks, Andrew > --- > Changes since v2: > - new patch > > sim/testsuite/sim/or1k/adrp.S | 73 +++++++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 sim/testsuite/sim/or1k/adrp.S > > diff --git a/sim/testsuite/sim/or1k/adrp.S b/sim/testsuite/sim/or1k/adrp.S > new file mode 100644 > index 0000000000..ba384ccc84 > --- /dev/null > +++ b/sim/testsuite/sim/or1k/adrp.S > @@ -0,0 +1,73 @@ > +/* Tests the load page address instruction. > + > + Copyright (C) 2017-2019 Free Software Foundation, Inc. This date range should just be '2019'. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +# mach: or1k > +# output: report(0x00002064);\n > +# output: report(0x00012138);\n > +# output: report(0x00002000);\n > +# output: report(0x00012000);\n > +# output: report(0x00002000);\n > +# output: report(0x00014000);\n > +# output: report(0x00000000);\n > +# output: exit(0)\n > + > +#include "or1k-asm-test-helpers.h" > + > + STANDARD_TEST_ENVIRONMENT > + > + .section .data > + .org 0x10000 > + .align 4 > + .type pi, @object > + .size pi, 4 > +pi: > + .float 3.14159 > + > + .section .text > +start_tests: > + PUSH LINK_REGISTER_R9 > + > + /* Print out the PC. To compare with that loaded by l.adrp. */ > + l.jal capture_pc > + l.nop > +capture_pc: > + REPORT_REG_TO_CONSOLE r9 > + > + /* Print out our data address to compared with l.adrp offset. */ > + l.movhi r11, ha(pi) > + l.addi r11, r11, lo(pi) > + REPORT_REG_TO_CONSOLE r11 > + > + /* Test l.adrp with symbols, loads page of symbol to register. */ > + l.adrp r4, start_tests > + REPORT_REG_TO_CONSOLE r4 > + > + l.adrp r4, pi > + REPORT_REG_TO_CONSOLE r4 > + > + /* Test l.adrp with immediate, immediate is the page offset. */ > + l.adrp r4, 0x0 > + REPORT_REG_TO_CONSOLE r4 > + > + l.adrp r4, 0x12000 > + REPORT_REG_TO_CONSOLE r4 > + > + l.adrp r4, -0x2000 > + REPORT_REG_TO_CONSOLE r4 > + > + POP LINK_REGISTER_R9 > + RETURN_TO_LINK_REGISTER_R9 > -- > 2.21.0 >