From: Jan Vrany <jan.vrany@fit.cvut.cz>
To: gdb-patches@sourceware.org
Cc: Jan Vrany <jan.vrany@fit.cvut.cz>
Subject: [PATCH v3 0/5] Create MI commands using python.
Date: Thu, 30 May 2019 13:49:00 -0000 [thread overview]
Message-ID: <20190530134850.3236-1-jan.vrany@fit.cvut.cz> (raw)
In-Reply-To: <20190128124101.26243-1-jan.vrany@fit.cvut.cz>
This version mainly addresses comments raised by Simon. Tested with both
Python 2.7 and Python 3(.7).
Changes v2 -> v3
* addressed Simon's comments:
- https://sourceware.org/ml/gdb-patches/2019-05/msg00406.html
- https://sourceware.org/ml/gdb-patches/2019-05/msg00407.html
* checked that it compiles with both Python 2.7 and Python 3(.7)
* add tests for MI command returning dictionary with non-string
keys
* add tests for creating MI commands with invalid names
Changes v1 -> v2
* squashed following commits into one:
- 8e65585bdab0 Create MI commands using python.
- 9e2afadd2d4d03 mi/python: C++ify python MI command handling code
- 0491a0634f7de4 mi/python: Polish MI output of python commands
* moved class mi_command_py to python code
* use gdbpy_ref<> instead of void* to hold on Python object
in mi_command_py
* release python objects held on by mi_command_py objects
when finalizing Python
* merged py_mi_invoke() into mi_command_py::invoke()
* added missing copyright headers
* dropped micmdpy_parse_command_name()
* prefixed error messages by MI command name except for
"Problem parsing arguments:" since old C-implemented MI
commands do not prefix command name.
* make do_suppress_notification() to return gdb::optional
* split invoke to invoke and do_invoke, making invoke to perform
common initialization
* add test redefining Python MI command while the very same command
is running
* documented the fact that in mi_command_py::do_invoke() `this` pointer cannot
be used after invoking python code since it may got stale.
Didier Nadeau (3):
Use std::map for MI commands in mi-cmds.c
Use classes to represent MI Command instead of structures
Create MI commands using python.
Jan Vrany (2):
mi/python: Allow redefinition of python MI commands
mi/python: Add tests for python-defined MI commands
gdb/ChangeLog | 88 +++++
gdb/Makefile.in | 1 +
gdb/mi/mi-cmd-info.c | 4 +-
gdb/mi/mi-cmds.c | 510 +++++++++++++------------
gdb/mi/mi-cmds.h | 87 ++++-
gdb/mi/mi-main.c | 22 +-
gdb/mi/mi-main.h | 1 +
gdb/mi/mi-parse.c | 20 +-
gdb/mi/mi-parse.h | 6 +-
gdb/python/py-micmd.c | 307 +++++++++++++++
gdb/python/py-micmd.h | 60 +++
gdb/python/python-internal.h | 2 +
gdb/python/python.c | 13 +-
gdb/testsuite/ChangeLog | 5 +
gdb/testsuite/gdb.python/py-mi-cmd.exp | 132 +++++++
gdb/testsuite/gdb.python/py-mi-cmd.py | 54 +++
16 files changed, 1007 insertions(+), 305 deletions(-)
create mode 100644 gdb/python/py-micmd.c
create mode 100644 gdb/python/py-micmd.h
create mode 100644 gdb/testsuite/gdb.python/py-mi-cmd.exp
create mode 100644 gdb/testsuite/gdb.python/py-mi-cmd.py
--
2.20.1
next prev parent reply other threads:[~2019-05-30 13:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 22:30 [PATCH] MI: Add new command -complete Jan Vrany
2019-01-16 9:21 ` Jan Vrany
[not found] ` <87imynm3ia.fsf@tromey.com>
2019-01-17 21:01 ` Jan Vrany
2019-01-28 12:41 ` [PATCH v2 0/2] " Jan Vrany
2019-01-28 12:41 ` [PATCH v2 1/2] MI: extract command completion logic from complete_command() Jan Vrany
2019-02-27 20:41 ` Pedro Alves
[not found] ` <9ddd13d90ac5d77067f5690743149be8a2dcdd1a.camel@fit.cvut.cz>
2019-02-13 9:24 ` [PATCH v2 0/2] MI: Add new command -complete Jan Vrany
2019-02-19 7:33 ` Jan Vrany
2019-02-20 21:20 ` Tom Tromey
2019-02-21 16:05 ` Jan Vrany
2019-02-26 19:49 ` Tom Tromey
2019-02-27 10:41 ` Jan Vrany
2019-02-27 20:41 ` Pedro Alves
2019-02-28 10:18 ` Jan Vrany
2019-03-05 20:53 ` Pedro Alves
2019-03-06 15:09 ` Jan Vrany
2019-03-06 15:45 ` Eli Zaretskii
2019-03-06 16:37 ` Jan Vrany
2019-03-06 17:36 ` Eli Zaretskii
2019-03-04 14:52 ` [PATCH v3 1/2] MI: extract command completion logic from complete_command() Jan Vrany
2019-03-04 14:52 ` [PATCH v3 0/2] MI: Add new command -complete Jan Vrany
2019-03-04 14:52 ` [PATCH v3 2/2] " Jan Vrany
2019-03-04 17:35 ` Eli Zaretskii
2019-04-03 19:23 ` Pedro Alves
2019-04-18 11:59 ` [PATCH v4 1/2] MI: extract command completion logic from complete_command() Jan Vrany
2019-04-18 11:59 ` [PATCH v4 2/2] MI: Add new command -complete Jan Vrany
2019-04-18 12:51 ` Eli Zaretskii
2019-04-18 14:15 ` Pedro Alves
2019-04-18 14:55 ` Jan Vrany
2019-04-18 16:14 ` Pedro Alves
2019-05-16 11:27 ` Jan Vrany
2019-05-16 17:31 ` Tom Tromey
2019-04-18 11:59 ` [PATCH v4 0/2] " Jan Vrany
2019-04-18 14:59 ` [PATCH v5 2/2] " Jan Vrany
2019-04-18 15:23 ` Eli Zaretskii
2019-04-18 14:59 ` [PATCH v5 1/2] MI: extract command completion logic from complete_command() Jan Vrany
2019-04-18 14:59 ` [PATCH v5 0/2] MI: Add new command -complete Jan Vrany
2019-05-30 13:49 ` [PATCH v3 1/5] Use std::map for MI commands in mi-cmds.c Jan Vrany
2019-05-30 13:49 ` Jan Vrany [this message]
2019-06-10 12:20 ` [PATCH v3 0/5] Create MI commands using python Jan Vrany
2019-05-30 13:49 ` [PATCH v3 3/5] " Jan Vrany
2019-06-18 19:43 ` Pedro Alves
2019-05-30 13:49 ` [PATCH v3 2/5] Use classes to represent MI Command instead of structures Jan Vrany
2019-06-18 19:38 ` Pedro Alves
2019-05-30 13:49 ` [PATCH v3 4/5] mi/python: Allow redefinition of python MI commands Jan Vrany
2019-06-18 20:03 ` Pedro Alves
2019-05-30 14:19 ` [PATCH v3 5/5] mi/python: Add tests for python-defined " Jan Vrany
2019-06-18 20:11 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530134850.3236-1-jan.vrany@fit.cvut.cz \
--to=jan.vrany@fit.cvut.cz \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox