From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123189 invoked by alias); 21 May 2019 20:10:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123180 invoked by uid 89); 21 May 2019 20:10:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f43.google.com Received: from mail-wr1-f43.google.com (HELO mail-wr1-f43.google.com) (209.85.221.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 May 2019 20:10:32 +0000 Received: by mail-wr1-f43.google.com with SMTP id d9so7058319wrx.0 for ; Tue, 21 May 2019 13:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y4UxJiPKloJ0wwnUln0LS8PbpbmT5OHsqG6cC3W/mI8=; b=MzmAy0B8KuOWzsh2Lk05RCfqw99uZeCrkE+wxp8mZWRdedyoFtCJNdXRL3Bql9vbVo WGxB3eHyeIuOM2hYiPsRWLoHGLkSQf721/F2ZdLCiqw0FOyReEt5z/FSEGblHke6rteW w6VhxySgzhvh+H3O5VsupUQ4Fqy8NcWKW70f4vD52NFRVyuL35mtGpeX+IckfJt7lABe TJZ9kdvJPErkeq50CGfAbvuBzyTe9ndG5cSgx8a49pHE+z4tCzYVFhqQJZSGAx5WK/Is 99cSDP8EeMxrBWWCxX7HsSSUrq+pzAmc4SFouISjg7excVNghfnMVVdmLdUte+07WQj9 xrpw== Return-Path: Received: from localhost ([2a00:23c5:3e8d:6c00:9cd0:87cb:29bd:5b8f]) by smtp.gmail.com with ESMTPSA id j123sm1653852wmb.32.2019.05.21.13.10.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 May 2019 13:10:29 -0700 (PDT) Date: Tue, 21 May 2019 20:10:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2] gdb/fortran: Use floatformats_ia64_quad for fortran 16-byte floats Message-ID: <20190521201028.GG2568@embecosm.com> References: <20190504121734.5868-1-andrew.burgess@embecosm.com> <20190516160058.17361-1-andrew.burgess@embecosm.com> <20190518085431.GZ2568@embecosm.com> <8736l7g5bk.fsf@tromey.com> <20190521165324.GF2568@embecosm.com> <87woijeo0r.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87woijeo0r.fsf@tromey.com> X-Fortune: The price of greatness is responsibility. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00480.txt.bz2 * Tom Tromey [2019-05-21 13:05:40 -0400]: > Andrew> Sorry for breaking this. > > Thanks! Don't feel too bad, though, I think the occasional bug like > this is going to creep in. > > Andrew> Or maybe we should be even more restrictive, and only use long double > Andrew> format if its the correct length, like: > > This seems to make the most sense to me, but I don't actually know > Fortran, so I'm just guessing. Honestly, I don't know the specifics here either. I suspect the real answer is that different targets and maybe even different Fortran compilers could use different formats for 16-byte floats. The intention with my change was to allow each target to find something suitable (clearly that didn't quite work). I think falling back to long double means we're no worse off than we were. If long double turns out to be wrong for other targets they can always implement gdbarch_floatformat_for_type like i386 does. Would you like me to push a fix, or do you want to do it? Thanks, Andrew