From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156124-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27294 invoked by alias); 16 May 2019 13:14:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27281 invoked by uid 89); 16 May 2019 13:14:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=bird, Bird, HX-Languages-Length:775
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 May 2019 13:14:28 +0000
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 7B22C307D84F;	Thu, 16 May 2019 13:14:27 +0000 (UTC)
Received: from blade.nx (ovpn-117-134.ams2.redhat.com [10.36.117.134])	by smtp.corp.redhat.com (Postfix) with ESMTP id 414271001DE6;	Thu, 16 May 2019 13:14:27 +0000 (UTC)
Received: by blade.nx (Postfix, from userid 1000)	id EFE4382D198B; Thu, 16 May 2019 14:14:20 +0100 (BST)
Date: Thu, 16 May 2019 13:14:00 -0000
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Cc: Amos Bird <amosbird@gmail.com>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] Add "thread-exited" annotation
Message-ID: <20190516131419.GA29999@blade.nx>
References: <87d0l8pzdz.fsf@gmail.com> <87ef5j33au.fsf@tromey.com> <87ftpzo1wa.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ftpzo1wa.fsf@gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2019-05/txt/msg00356.txt.bz2

Hi Amos,

I've only the two nits detailed below, other than those the patch
seems fine.

Cheers,
Gary

Amos Bird wrote:
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 5309a8f923..df5f836bac 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,8 @@
>  
>  *** Changes since GDB 8.3
>  
> +* 'thread-exited' event is now available in the old annotations interface

I'd lose the "old" here.

> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 9b0725a033..169b5b8dce 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-04-26  Amos Bird  <amosbird@gmail.com>
> +
> +	* gdb.base/annota1.exp (thread_switch): Test for thread-exited
> +	annotation.
> +

I'd say "Add test..." here.