From: Jan Vrany <jan.vrany@fit.cvut.cz>
To: gdb-patches@sourceware.org
Cc: Jan Vrany <jan.vrany@fit.cvut.cz>
Subject: [PATCH v2 0/5] Create MI commands using python
Date: Tue, 14 May 2019 11:24:00 -0000 [thread overview]
Message-ID: <20190514112418.24091-1-jan.vrany@fit.cvut.cz> (raw)
In-Reply-To: <20190418152337.6376-1-jan.vrany@fit.cvut.cz>
This is a rework of previous patch series based on Tom's and Simon's
comments. I may happen that I overlooked something since some of
the issues were addressed in subsequent commits and a lot of code
was moved around.
This version *does not* use std::shared_ptr to hold on MI commands, instead
it makes sure that `this` pointer is not used after it me become stale.
Changes v1 -> v2
* squashed following commits into one:
- 8e65585bdab0 Create MI commands using python.
- 9e2afadd2d4d03 mi/python: C++ify python MI command handling code
- 0491a0634f7de4 mi/python: Polish MI output of python commands
* moved class mi_command_py to python code
* use gdbpy_ref<> instead of void* to hold on Python object
in mi_command_py
* release python objects held on by mi_command_py objects
when finalizing Python
* merged py_mi_invoke() into mi_command_py::invoke()
* added missing copyright headers
* dropped micmdpy_parse_command_name()
* prefixed error messages by MI command name except for
"Problem parsing arguments:" since old C-implemented MI
commands do not prefix command name.
* make do_suppress_notification() to return gdb::optional
* split invoke to invoke and do_invoke, making invoke to perform
common initialization
* add test redefining Python MI command while the very same command
is running
* documented the fact that in mi_command_py::do_invoke() `this` pointer cannot
be used after invoking python code since it may got stale.
Didier Nadeau (3):
Use std::map for MI commands in mi-cmds.c
Use classes to represent MI Command instead of structures
Create MI commands using python.
Jan Vrany (2):
mi/python: Allow redefinition of python MI commands
mi/python: Add tests for python-defined MI commands
gdb/ChangeLog | 88 +++++
gdb/Makefile.in | 1 +
gdb/mi/mi-cmd-info.c | 4 +-
gdb/mi/mi-cmds.c | 501 +++++++++++++------------
gdb/mi/mi-cmds.h | 87 +++--
gdb/mi/mi-main.c | 18 +-
gdb/mi/mi-main.h | 1 +
gdb/mi/mi-parse.c | 20 +-
gdb/mi/mi-parse.h | 6 +-
gdb/python/py-micmd.c | 308 +++++++++++++++
gdb/python/py-micmd.h | 52 +++
gdb/python/python-internal.h | 2 +
gdb/python/python.c | 13 +-
gdb/testsuite/ChangeLog | 5 +
gdb/testsuite/gdb.python/py-mi-cmd.exp | 109 ++++++
gdb/testsuite/gdb.python/py-mi-cmd.py | 39 ++
16 files changed, 959 insertions(+), 295 deletions(-)
create mode 100644 gdb/python/py-micmd.c
create mode 100644 gdb/python/py-micmd.h
create mode 100644 gdb/testsuite/gdb.python/py-mi-cmd.exp
create mode 100644 gdb/testsuite/gdb.python/py-mi-cmd.py
--
2.20.1
next prev parent reply other threads:[~2019-05-14 11:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 15:23 [RFC 0/8] " Jan Vrany
2019-04-18 15:23 ` [RFC 1/8] Use std::map for MI commands in mi-cmds.c Jan Vrany
2019-04-25 19:13 ` Tom Tromey
2019-04-25 19:15 ` Tom Tromey
2019-04-25 19:34 ` Jan Vrany
2019-05-03 22:40 ` Simon Marchi
2019-05-03 22:45 ` Simon Marchi
2019-04-18 15:24 ` [RFC 3/8] Create MI commands using python Jan Vrany
2019-04-25 19:42 ` Tom Tromey
2019-04-18 15:24 ` [RFC 8/8] mi/python: Allow redefinition of python MI commands Jan Vrany
2019-04-25 19:50 ` Tom Tromey
2019-05-03 15:26 ` Jan Vrany
2019-05-06 21:40 ` Tom Tromey
2019-05-07 11:26 ` Jan Vrany
2019-05-07 13:09 ` Simon Marchi
2019-05-07 13:19 ` Jan Vrany
2019-05-08 0:10 ` Simon Marchi
2019-05-08 18:00 ` Tom Tromey
2019-04-18 15:24 ` [RFC 4/8] mi/python: C++ify python MI command handling code Jan Vrany
2019-04-25 19:43 ` Tom Tromey
2019-04-18 15:24 ` [RFC 2/8] Use classes to represent MI Command instead of structures Jan Vrany
2019-04-25 19:25 ` Tom Tromey
2019-05-03 22:49 ` Simon Marchi
2019-05-03 22:57 ` Simon Marchi
2019-04-18 15:24 ` [RFC 6/8] mi/python: Handle python exception when executiong python-defined MI commands Jan Vrany
2019-04-25 19:46 ` Tom Tromey
2019-04-26 10:19 ` Jan Vrany
2019-04-18 15:24 ` [RFC 7/8] mi/python: Add tests for " Jan Vrany
2019-04-25 19:48 ` Tom Tromey
2019-04-18 16:03 ` [RFC 0/8] Create MI commands using python Simon Marchi
2019-04-20 7:20 ` Jan Vrany
2019-04-18 16:12 ` [RFC 5/8] mi/python: Polish MI output of python commands Jan Vrany
2019-04-25 19:50 ` Tom Tromey
2019-04-25 18:03 ` [RFC 0/8] Create MI commands using python Tom Tromey
2019-04-25 19:00 ` Simon Marchi
2019-04-25 19:01 ` Simon Marchi
2019-05-14 11:24 ` [PATCH v2 2/5] Use classes to represent MI Command instead of structures Jan Vrany
2019-05-17 3:12 ` Simon Marchi
2019-05-14 11:24 ` [PATCH v2 1/5] Use std::map for MI commands in mi-cmds.c Jan Vrany
2019-05-14 11:24 ` [PATCH v2 3/5] Create MI commands using python Jan Vrany
2019-05-17 4:29 ` Simon Marchi
2019-05-28 20:35 ` Jan Vrany
2019-05-14 11:24 ` [PATCH v2 5/5] mi/python: Add tests for python-defined MI commands Jan Vrany
2019-05-14 11:24 ` Jan Vrany [this message]
2019-05-14 11:57 ` [PATCH v2 4/5] mi/python: Allow redefinition of python " Jan Vrany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514112418.24091-1-jan.vrany@fit.cvut.cz \
--to=jan.vrany@fit.cvut.cz \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox