From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: gdb-patches@sourceware.org
Subject: [RFAv3 0/6] Implement | (pipe) command.
Date: Sat, 04 May 2019 16:18:00 -0000 [thread overview]
Message-ID: <20190504161753.15530-1-philippe.waroquiers@skynet.be> (raw)
Implement | (pipe) command.
This patch series adds the pipe command, that allows to send the output
of a GDB command to a shell command.
This is the third version, handling the comments of Pedro.
The doc, help and NEWS are changed in this version, so must be
re-reviewed.
* Comments of Pedro:
* Implement -d SEP (SEP being a string) instead of -dX.
* popen has been kept as libiberty pexecute still implies to use
the WIF* macros. However, exit status handling reworked to go via
convenience variables, rather than being shown to the user.
* various small changes (== '\0', Skip, ...).
* simplified error messages to just indicate with a static string
what argument is wrong or missing.
* extended the test to verify all error handling messages and check
the new convenience variables $_shell_exitcode and $_shell_exitsignal.
* Comments from Eli :
* better definition of WIF* macros for MinGW.
* replace @ref by @xref in the doc.
* Comment from Abhijit Halder/Tom:
* it not that unlikely to have | in a GDB command
=> an optional -d SEP option allows to specify an
alternate string to use SEP to replace the | as separator
between the GDB COMMAND and the SHELL_COMMAND.
* Comments from Tom:
* make previous_saved_command_line static. For this, saved_command_line
is now also static, and all repeat related functions/vars are now
in top.c
* various small changes (use std::swap, strchr, .empty (), ...).
* removed the scoped_restore_current_thread restore
* popen has been kept as libiberty pexecute still implies to use
the WIF* macros.
* Instead of using execute_command_to_string, use GDB redirection
mechanism. I did several trials for this, and at the end,
the only one working properly was very close to the code
of execute_command_to_string.
=> we now have a function execute_command_to_ui_file that is used
to implement the pipe command, and also used by
execute_command_to_string.
next reply other threads:[~2019-05-04 16:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 16:18 Philippe Waroquiers [this message]
2019-05-04 16:18 ` [RFAv3 5/6] Test the " Philippe Waroquiers
2019-05-27 17:49 ` Pedro Alves
2019-05-04 16:18 ` [RFAv3 1/6] Add previous_saved_command_line to allow a command to repeat a previous command Philippe Waroquiers
2019-05-27 17:29 ` Pedro Alves
2019-05-04 16:18 ` [RFAv3 3/6] Add function execute_command_to_ui_file Philippe Waroquiers
2019-05-04 16:18 ` [RFAv3 6/6] NEWS and documentation for | (pipe) command Philippe Waroquiers
2019-05-04 16:26 ` Eli Zaretskii
2019-05-04 16:33 ` Eli Zaretskii
2019-05-27 17:51 ` Pedro Alves
2019-05-04 16:18 ` [RFAv3 2/6] Improve process exit status macros on MinGW Philippe Waroquiers
2019-05-27 17:33 ` Pedro Alves
2019-05-27 18:38 ` Eli Zaretskii
2019-05-29 12:38 ` Pedro Alves
2019-05-29 15:03 ` Eli Zaretskii
2019-05-30 10:26 ` Philippe Waroquiers
2019-12-17 17:00 ` Eli Zaretskii
2019-12-17 17:51 ` Pedro Alves
2019-12-18 17:08 ` Eli Zaretskii
2019-12-18 17:42 ` Pedro Alves
2019-12-18 18:33 ` Eli Zaretskii
2019-12-25 15:57 ` Eli Zaretskii
2020-01-03 19:59 ` Pedro Alves
2020-01-03 20:08 ` Pedro Alves
2020-01-03 20:34 ` Eli Zaretskii
2020-01-06 11:57 ` Pedro Alves
2020-01-06 16:17 ` Eli Zaretskii
2020-01-06 18:51 ` Pedro Alves
2020-01-06 19:26 ` Eli Zaretskii
2020-01-06 18:59 ` Hannes Domani via gdb-patches
2020-01-06 19:34 ` Eli Zaretskii
2020-01-06 19:38 ` Hannes Domani via gdb-patches
2020-01-06 19:55 ` Eli Zaretskii
2020-01-03 17:04 ` Pedro Alves
2019-05-04 16:18 ` [RFAv3 4/6] Implement | (pipe) command Philippe Waroquiers
2019-05-27 17:48 ` Pedro Alves
2019-05-27 17:55 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504161753.15530-1-philippe.waroquiers@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox