From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54499 invoked by alias); 29 Apr 2019 21:14:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54491 invoked by uid 89); 29 Apr 2019 21:14:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:3205 X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Apr 2019 21:14:45 +0000 Received: by mail-wm1-f65.google.com with SMTP id j13so1096778wmh.2 for ; Mon, 29 Apr 2019 14:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iCjACD+P1gskGmaZtIgFYau2e8oEOF3E6nyZCs97l7U=; b=U4ODIG1nTXJYhAOogDfo6cX1hc+ttazHGyeKDSyAdqzzWoNme5vD8O0eufgL38BIs7 TcYdmVmuAksdhJyQMOjop5NvtzmIK5/2kvyX+1SnTfN/gXWcJb/vpMnkBWEsuLY0Mz0Q 3LloM5pyCOTNIKdb27PwX35O1Ks97TO2RJrFjOjdgYxn7W9AGYbZrj925s3az0jfBRRv bMC81UeCZ4e1uWtDbSZvd3zTEcnCiOsAB0vMbCS1dRl2H8MmA8MpqFB1dOjLsm0qeeBz 8RViSr3rTZtGtC93MvPQO3NToek+x5LtnU9YVdKrSjOGWrHU+48vijg16OU//Mze6Lj1 1Gyg== Return-Path: Received: from localhost (host109-154-100-57.range109-154.btcentralplus.com. [109.154.100.57]) by smtp.gmail.com with ESMTPSA id v25sm25306291wrv.7.2019.04.29.14.14.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 14:14:41 -0700 (PDT) Date: Mon, 29 Apr 2019 21:14:00 -0000 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/5] Add new 'print max-depth' feature Message-ID: <20190429211439.GQ2737@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: User hostile. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00637.txt.bz2 Thank you for all the feedback. I've now pushed this series. Thanks, Andrew * Andrew Burgess [2019-04-17 00:06:05 +0100]: > This revision hopefully addresses all of the feedback from the first > version. > > Patches #1 and #2 are new, minor clean up patches. > > Patch #3 (previously #1) is unchanged. > > Patch #4 is new, this adds a new predicate to the language structure > to decide if a given type is a string or not. > > Patch #5 this is updated from the previous version, there's more > documentation, many more tests, minor code issues identified in v1 > have been addressed. > > -- > > Andrew Burgess (5): > gdb/ada: Update some predicate functions to return bool > gdb/testsuite: Don't add gcc flags when compiling rust tests > gdb: Introduce new language field la_struct_too_deep_ellipsis > gdb: Introduce new language field la_is_string_type_p > gdb: Introduce 'print max-depth' feature > > gdb/ChangeLog | 85 +++++++++ > gdb/NEWS | 9 + > gdb/ada-lang.c | 12 +- > gdb/ada-lang.h | 4 +- > gdb/c-lang.c | 47 ++++- > gdb/c-lang.h | 5 + > gdb/cp-valprint.c | 80 +++++---- > gdb/d-lang.c | 4 +- > gdb/doc/ChangeLog | 8 + > gdb/doc/gdb.texinfo | 70 ++++++++ > gdb/doc/guile.texi | 3 + > gdb/doc/python.texi | 8 + > gdb/f-lang.c | 14 +- > gdb/go-lang.c | 14 +- > gdb/guile/scm-pretty-print.c | 19 +- > gdb/language.c | 22 ++- > gdb/language.h | 13 ++ > gdb/m2-lang.c | 25 ++- > gdb/objc-lang.c | 4 +- > gdb/opencl-lang.c | 4 +- > gdb/p-lang.c | 14 +- > gdb/python/py-prettyprint.c | 15 +- > gdb/python/py-value.c | 7 +- > gdb/rust-lang.c | 24 ++- > gdb/testsuite/ChangeLog | 23 +++ > gdb/testsuite/gdb.base/max-depth.c | 232 +++++++++++++++++++++++++ > gdb/testsuite/gdb.base/max-depth.exp | 165 ++++++++++++++++++ > gdb/testsuite/gdb.fortran/max-depth.exp | 41 +++++ > gdb/testsuite/gdb.fortran/max-depth.f90 | 42 +++++ > gdb/testsuite/gdb.go/max-depth.exp | 40 +++++ > gdb/testsuite/gdb.go/max-depth.go | 41 +++++ > gdb/testsuite/gdb.modula2/max-depth.c | 45 +++++ > gdb/testsuite/gdb.modula2/max-depth.exp | 37 ++++ > gdb/testsuite/gdb.python/py-format-string.exp | 21 +++ > gdb/testsuite/gdb.python/py-nested-maps.c | 130 ++++++++++++++ > gdb/testsuite/gdb.python/py-nested-maps.exp | 238 ++++++++++++++++++++++++++ > gdb/testsuite/gdb.python/py-nested-maps.py | 135 +++++++++++++++ > gdb/testsuite/lib/gdb.exp | 36 +++- > gdb/valprint.c | 56 +++++- > gdb/valprint.h | 12 ++ > 40 files changed, 1746 insertions(+), 58 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/max-depth.c > create mode 100644 gdb/testsuite/gdb.base/max-depth.exp > create mode 100644 gdb/testsuite/gdb.fortran/max-depth.exp > create mode 100644 gdb/testsuite/gdb.fortran/max-depth.f90 > create mode 100644 gdb/testsuite/gdb.go/max-depth.exp > create mode 100644 gdb/testsuite/gdb.go/max-depth.go > create mode 100644 gdb/testsuite/gdb.modula2/max-depth.c > create mode 100644 gdb/testsuite/gdb.modula2/max-depth.exp > create mode 100644 gdb/testsuite/gdb.python/py-nested-maps.c > create mode 100644 gdb/testsuite/gdb.python/py-nested-maps.exp > create mode 100644 gdb/testsuite/gdb.python/py-nested-maps.py > > -- > 2.14.5 >