From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10774 invoked by alias); 29 Apr 2019 18:31:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10756 invoked by uid 89); 29 Apr 2019 18:31:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=ended, sergio, H*F:U*tromey, HX-Envelope-From:sk:tromey@ X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Apr 2019 18:31:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D675F117167 for ; Mon, 29 Apr 2019 14:31:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jd0PvjqDk8DC for ; Mon, 29 Apr 2019 14:31:06 -0400 (EDT) Received: from murgatroyd.Home (97-122-168-123.hlrn.qwest.net [97.122.168.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 8A24F1170BD for ; Mon, 29 Apr 2019 14:31:06 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 0/2] two ptype/o changes Date: Mon, 29 Apr 2019 18:31:00 -0000 Message-Id: <20190429183105.15973-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-04/txt/msg00627.txt.bz2 This series changes ptype/o in a couple of ways. Last week I spent quite some time puzzling over the meaning of the 'offset' for a bitfield in ptype/o output. After talking with Sergio on irc, I ended up concluding that gdb should instead print the bit offset, not the number of bits remaining in the field's allocation. That is patch #2. Then, I noticed that the tests did not fail, despite the output changing. It turns out the tests weren't working correctly, so I wrote patch #1. Tested on x86-64 Fedora 29. Let me know what you think. Patch #2 includes a doc change. Tom