From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103074 invoked by alias); 18 Apr 2019 14:54:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103065 invoked by uid 89); 18 Apr 2019 14:54:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=balance, invest X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 14:54:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8CFFC561B2; Thu, 18 Apr 2019 10:54:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Oh31g4nCgf62; Thu, 18 Apr 2019 10:54:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5ABB55602B; Thu, 18 Apr 2019 10:54:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 87A2B83C06; Thu, 18 Apr 2019 07:54:19 -0700 (PDT) Date: Thu, 18 Apr 2019 14:54:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global Message-ID: <20190418145419.GA5965@adacore.com> References: <1555453982-77808-1-git-send-email-brobecker@adacore.com> <1555453982-77808-3-git-send-email-brobecker@adacore.com> <83imvcg0ud.fsf@gnu.org> <20190417173842.GA14817@adacore.com> <83wojseb9c.fsf@gnu.org> <20190417221729.GA5839@adacore.com> <83imvbearj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83imvbearj.fsf@gnu.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-04/txt/msg00321.txt.bz2 > > Personally, I feel the other way, especially since we always get > > all sorts of random temporary thread notifications polutting the > > output, that I don't mind the extra notification. And that way, > > I know when each thread is actually terminated, and with what > > error code. > > > > But if you and others feel differently, I can switch my approach: > > > > - patch #1 (master+8.3): Just fix the crash, and nothing more. > > > > This means that, on 8.3, thread creation and exit notifications > > can be slightly off; this is considered an acceptable known > > problem, and is not a regression. > > > > This is actually what we've put in AdaCore's GDB as a first > > step to see we had any issue after that, and we did not. > > > > - patch #2 (master only): Remove uses of the global > > > > But we keep the filtering of the "main" thread. We still > > the known problem that the thread-exit notifications might > > be silenced for the wrong thread. Not a regression. > > > > - patch #3 (master only): Tag the main thread, and silence > > the thread-exit notification of the thread that got tagged. > > Depending on the implementation, this patch would potentially > > be acceptable for 8.3, but might need extra work to apply. > > I think we've had enough problems with 8.3 as it is, I don't > > want to add more things to do, so I vote OUT for 8.3. > > > > I don't think I have time for that before the weekend or next week, > > though. > > Mine is just one opinion. I think we should solicit opinions from > others before you invest all that effort. If I'm the only one who is > bothered by your original proposal, I think you should go ahead and > push it. Since I think you use the debugger on Windows more than I personally do, I'll go the other way. Unless someone else tips the balance the other way, I'll go with your opinion over mine ;-). -- Joel