From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38781 invoked by alias); 18 Apr 2019 20:38:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38759 invoked by uid 89); 18 Apr 2019 20:38:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=awake X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 20:38:48 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EC177E44B; Thu, 18 Apr 2019 20:38:47 +0000 (UTC) Received: from f29-4.lan (ovpn-116-111.phx2.redhat.com [10.3.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17F7160851; Thu, 18 Apr 2019 20:38:47 +0000 (UTC) Date: Thu, 18 Apr 2019 20:38:00 -0000 From: Kevin Buettner To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: Fix compilation using mingw.org's MinGW Message-ID: <20190418133846.7dca95c2@f29-4.lan> In-Reply-To: <83zhoncfg2.fsf@gnu.org> References: <835zrbe36c.fsf@gnu.org> <20190418100058.34c64f18@f29-4.lan> <83zhoncfg2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00360.txt.bz2 On Thu, 18 Apr 2019 21:54:05 +0300 Eli Zaretskii wrote: > > Date: Thu, 18 Apr 2019 10:00:58 -0700 > > From: Kevin Buettner > > Cc: gdb-patches@sourceware.org > > > > > +#if _WIN32_WINNT < 0x0501 > > > + > > > +typedef > > > +struct _CONSOLE_FONT_INFO > > > +{ DWORD nFont; > > > + COORD dwFontSize; > > > +} CONSOLE_FONT_INFO, *PCONSOLE_FONT_INFO; > > > + > > > +#endif > > > + > > > typedef BOOL WINAPI (AdjustTokenPrivileges_ftype) (HANDLE, BOOL, > > > PTOKEN_PRIVILEGES, > > > DWORD, PTOKEN_PRIVILEGES, > > > > I had expected to see a typedef for struct CONSOLE_FONT_INFO, but > > instead see one for _CONSOLE_FONT_INFO (where the difference is > > the leading underscore.) > > The struct is with the leading underscore, the typedef isn't. > > > I'm guessing that there's some magic in Windows specific header files > > which makes this work, but I just want to check to make sure that this > > wasn't a typo on your part... > > It wasn't a typo, and there is no magic ;-) Apologies - I clearly wasn't awake enough when I looked at your patch. So... no objections from me regarding this patch. Kevin