From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6756 invoked by alias); 18 Apr 2019 01:07:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6747 invoked by uid 89); 18 Apr 2019 01:07:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f43.google.com Received: from mail-wr1-f43.google.com (HELO mail-wr1-f43.google.com) (209.85.221.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 01:07:30 +0000 Received: by mail-wr1-f43.google.com with SMTP id o12so716388wrn.2 for ; Wed, 17 Apr 2019 18:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=app6B2ag0mH4Wmz7uaLlU9A1ou3+2hpZqg6rGmic2LA=; b=D0Ti0QV/FDm1VEpCL502/PatZRzGdcfoSYNmQEHFVT3BKpl+874Ht8P3pgRKsXHwwW tNAeMmR7UUc+4PvILkNjM9Ado9KynI3vsluJU7AWW0IiBeaq/BQcxyU4nlnRUzBUbtZN QLJI6HSmmtu0CqEozi7z9VywMrSDA2b7vTS9ixbXfYnCPQRnZQIZ+lsur4oXHg8fdYAH ib8AWVaoilcelqKRLCu+4qlOKGe4f7loVyCRHBExMvOyJ/wrqqZhzR4Dwdgm294rHIAZ hlwnWuyap5NbM6C6EukPM9fLooRo2zd+bSSkrdoohyRy5WT36hLKRAU7wc5UYrtupUEI adNQ== Return-Path: Received: from localhost (host86-164-133-98.range86-164.btcentralplus.com. [86.164.133.98]) by smtp.gmail.com with ESMTPSA id o130sm401182wmo.43.2019.04.17.18.07.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 18:07:27 -0700 (PDT) Date: Thu, 18 Apr 2019 01:07:00 -0000 From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature Message-ID: <20190418010726.GS2737@embecosm.com> References: <5cbfdd5672b59422d41f4b3c0ca20a9d45c20442.1555455013.git.andrew.burgess@embecosm.com> <83h8awg0nk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83h8awg0nk.fsf@gnu.org> X-Fortune: He walks as if balancing the family tree on his nose. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00306.txt.bz2 * Eli Zaretskii [2019-04-17 17:35:27 +0300]: > > From: Andrew Burgess > > Cc: Andrew Burgess > > Date: Wed, 17 Apr 2019 00:06:10 +0100 > > > > Introduce a new print setting max-depth which can be set with 'set > > print max-depth DEPTH'. The default value of DEPTH is 20, but this > > can also be set to unlimited. > > OK for the documentation parts, with one minor comment: > > > +To see the contents of structures that have been hidden the user can > > +either increase the print max-depth to increase, or they can print > > "increase ... to increase" sounds awkward and perhaps even confusing. > Can we come up with a better wording? You're right, that doesn't read well, how about simply dropping the '...to increase' like this: +To see the contents of structures that have been hidden the user +can either increase the print max-depth, or they can print the +elements of the structure that are visible, for example + +@smallexample +(gdb) p var +$1 = @{d = @{c = @{...@}@}@} +(gdb) p var.d +$2 = @{c = @{b = @{...@}@}@} +(gdb) p var.d.c +$3 = @{b = @{a = 3@}@} +@end smallexample + Thanks, Andrew > > Thanks.