From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17993 invoked by alias); 18 Apr 2019 00:03:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17978 invoked by uid 89); 18 Apr 2019 00:03:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=ada-lang.h, UD:ada-lang.h, adalangh, UD:ada-lang.c X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 00:03:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BF4F65600E; Wed, 17 Apr 2019 20:03:38 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vPukDixjY+ZB; Wed, 17 Apr 2019 20:03:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8CE6F116CD8; Wed, 17 Apr 2019 20:03:38 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A0E1783C06; Wed, 17 Apr 2019 17:03:36 -0700 (PDT) Date: Thu, 18 Apr 2019 00:03:00 -0000 From: Joel Brobecker To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 1/5] gdb/ada: Update some predicate functions to return bool Message-ID: <20190418000336.GA17959@adacore.com> References: <0ad8f4f39a6eaabe2e97467dc6f53aea89800d7e.1555455013.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ad8f4f39a6eaabe2e97467dc6f53aea89800d7e.1555455013.git.andrew.burgess@embecosm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-04/txt/msg00305.txt.bz2 Hi Andrew, On Wed, Apr 17, 2019 at 12:06:06AM +0100, Andrew Burgess wrote: > A later commit would like to make use of a pointer to the function > ada_is_string_type, however, this will require the function to return > a bool (so the signature matches). > > As the ada_is_string_type is a predicate function, and its return > value is only ever used as either true or false, then this commit > updates the function to return a bool. > > As a consequence ada_is_character_type needs to change too. > > There should be no user visible changes after this commit. > > gdb/ChangeLog: > > * ada-lang.c (ada_is_character_type): Change return type to bool. > (ada_is_string_type): Likewise. > * ada-lang.h (ada_is_character_type): Update declaration > (ada_is_string_type): Likewise. This a good change, so good for me! -- Joel