From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9885 invoked by alias); 18 Apr 2019 00:02:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9875 invoked by uid 89); 18 Apr 2019 00:02:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 00:02:14 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E3E9A971A; Thu, 18 Apr 2019 00:02:13 +0000 (UTC) Received: from f29-4.lan (ovpn-116-111.phx2.redhat.com [10.3.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64FCA5C21F; Thu, 18 Apr 2019 00:02:13 +0000 (UTC) Date: Thu, 18 Apr 2019 00:02:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: Re: [PATCH 3/3] gdb/nds32: Use type_align instead of nds32_type_align Message-ID: <20190417170212.0ac93cca@f29-4.lan> In-Reply-To: <20190417205945.GR2737@embecosm.com> References: <6e5973aace6c35e5edfd75ce7b268f44b7bd42a2.1555111225.git.andrew.burgess@embecosm.com> <20190414115352.4a3cb8a2@f29-4.lan> <20190417205945.GR2737@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00304.txt.bz2 On Wed, 17 Apr 2019 21:59:46 +0100 Andrew Burgess wrote: > * Kevin Buettner [2019-04-14 11:53:52 -0700]: > > > On Sat, 13 Apr 2019 00:25:34 +0100 > > Andrew Burgess wrote: > > > > > The general type_align method should be a suitable alternative to > > > nds32_type_align, so switch to use that. > > > > > > The only change this will introduce is related to static fields in a > > > struct or union, the existing code doesn't take account of static > > > fields when computing the alignment for structs of unions, though this > > > is probably a bug - which would probably be exposed by the test case > > > gdb.cp/many-args.exp, though I don't have any way to test this target > > > right now. > > > > > > gdb/ChangeLog: > > > > > > * nds32-tdep.c (nds32_type_align): Delete. > > > (nds32_push_dummy_call): Use type_align instead. > > > > I think that nds32_type_align needs to be registered in > > nds32_gdbarch_init(). > > No, I deleted nds32_type_align completely. It doesn't have any > special vector type handling, so the default type_align should be > fine. I see. This is okay then. (Sorry for not reading it more closely.) > The one change that will be seen is that the old nds32_type_align > counts static fields within structs when computing the alignment. I > haven't tried any testing, but I would guess this was a bug. Unless > someone has the ability to test the target I'll probably just push > this change, and if it turns out the static field handling is wrong, > then it's easy enough to fix later. I think that's fine. Kevin