From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72235 invoked by alias); 14 Apr 2019 18:54:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72225 invoked by uid 89); 14 Apr 2019 18:54:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 14 Apr 2019 18:54:35 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F267130842B0; Sun, 14 Apr 2019 18:54:33 +0000 (UTC) Received: from f29-4.lan (ovpn-116-111.phx2.redhat.com [10.3.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB6CD608C1; Sun, 14 Apr 2019 18:54:33 +0000 (UTC) Date: Sun, 14 Apr 2019 18:54:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: Re: [PATCH 1/3] gdb/aarch64: Use type_align instead of aarch64_type_align Message-ID: <20190414115433.3f7bd5ed@f29-4.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00257.txt.bz2 On Sat, 13 Apr 2019 00:25:32 +0100 Andrew Burgess wrote: > Replaces use of aarch64_type_align with common type_align function. > > Doing this fixes a bug in aarch64_type_align where static fields are > considered as part of the alignment calculation of a struct, which > results in arguments passed on the stack being misaligned. This bug > is exposed in the new test gdb.cp/many-args.exp. > > Part of the old aarch64_type_align is retained and used as the gdbarch > type align callback in order to correctly align vectors. > > gdb/ChangeLog: > > * aarch64-tdep.c (aarch64_type_align): Only handle vector override > case. > (pass_on_stack): Use type_align. > (aarch64_gdbarch_init): Register aarch64_type_align gdbarch > function. > > gdb/testsuite/ChangeLog: > > * gdb.cp/many-args.cc: New file. > * gdb.cp/many-args.exp: New file. LGTM. Kevin