From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59215 invoked by alias); 28 Mar 2019 09:50:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58976 invoked by uid 89); 28 Mar 2019 09:50:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.1 spammy=H*x:version, linuxlowc, linux-low.c, H*UA:version X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 09:50:44 +0000 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2S9m8oD072762 for ; Thu, 28 Mar 2019 05:50:42 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rguaxsuy0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 28 Mar 2019 05:50:42 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 28 Mar 2019 09:50:40 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 28 Mar 2019 09:50:38 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2S9obZE40698100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2019 09:50:37 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 551C711C054; Thu, 28 Mar 2019 09:50:37 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 405A311C04C; Thu, 28 Mar 2019 09:50:37 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.214.226]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 28 Mar 2019 09:50:37 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id A0EE1D802AE; Thu, 28 Mar 2019 10:50:36 +0100 (CET) Subject: Re: FW: [PATCH 2/2] gdbserver: Add linux_get_hwcap To: Alan.Hayward@arm.com (Alan Hayward) Date: Thu, 28 Mar 2019 09:50:00 -0000 From: "Ulrich Weigand" Cc: simark@simark.ca (Simon Marchi), gdb-patches@sourceware.org (gdb-patches@sourceware.org), nd@arm.com (nd) In-Reply-To: <21150CCC-CA17-4D7E-8432-E59791ADF248@arm.com> from "Alan Hayward" at Mar 26, 2019 02:34:44 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 19032809-0028-0000-0000-000003598150 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032809-0029-0000-0000-0000241840F0 Message-Id: <20190328095036.A0EE1D802AE@oc3748833570.ibm.com> X-SW-Source: 2019-03/txt/msg00701.txt.bz2 Alan Hayward wrote: > * linux-low.c (linux_get_auxv): New function. > (linux_get_hwcap): Likewise. > (linux_get_hwcap2): Likewise. This still breaks the build on my Cell/B.E. dailybuild: gdb/gdbserver/linux-low.c: In function 'CORE_ADDR linux_get_hwcap2(int)': gdb/gdbserver/linux-low.c:7471:36: error: 'AT_HWCAP2' was not declared in this scope return linux_get_auxv (wordsize, AT_HWCAP2); ^~~~~~~~~ The system (RHEL5) is so old that the system headers do not yet provide AT_HWCAP2. The old code worked because linux-ppc-low.c got the define via #include "elf/common.h", which linux-low.c does not include. I guess we should either have linux-low.c include the local file as well (if that is possible -- there may be conflicts with that is otherwise already included), or else provide a fallback define of AT_HWCAP2 only. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com