From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85161 invoked by alias); 26 Mar 2019 22:44:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85141 invoked by uid 89); 26 Mar 2019 22:44:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=HX-Languages-Length:775, noticed X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 22:44:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 09125116C34; Tue, 26 Mar 2019 18:44:00 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1F2ACu2N9QCC; Tue, 26 Mar 2019 18:43:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CDC67116C2F; Tue, 26 Mar 2019 18:43:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 253F883AE0; Tue, 26 Mar 2019 15:43:58 -0700 (PDT) Date: Tue, 26 Mar 2019 22:44:00 -0000 From: Joel Brobecker To: Pedro Franco de Carvalho Cc: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Prepare for DejaGnu 1.6.2 Message-ID: <20190326224358.GA29229@adacore.com> References: <20190307140450.22503-1-andrew.burgess@embecosm.com> <87h8bp2va0.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h8bp2va0.fsf@linux.vnet.ibm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-03/txt/msg00621.txt.bz2 > Thanks for this fix. > > I noticed that the 8.3 branch has the commit that redefines "cd" that > triggered the issue fixed here, but this fix is not present there. > > Would it make sense to include this in the 8.3 branch? I looked at the patch, and it looked safe to me. I also ran the testsuite with an older version of dejagnu (1.5.1), and it ran fine. So I backported the patch to the 8.3 branch. > > gdb/testsuite/ChangeLog: > > > > * config/default.exp: Remove 'load_lib gdb.exp'. > > * config/monitor.exp: Likewise. > > * config/sid.exp: Likewise. > > * config/sim.exp: Likewise. > > * config/slite.exp: Likewise. > > * config/unix.exp: Likewise. > > * gdb.base/default.exp: Remove unhelpful comment. -- Joel