From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45031 invoked by alias); 24 Mar 2019 10:27:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45015 invoked by uid 89); 24 Mar 2019 10:27:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=colors, HX-Languages-Length:524, accepting, HX-Received:ac8 X-HELO: mail-qt1-f195.google.com Received: from mail-qt1-f195.google.com (HELO mail-qt1-f195.google.com) (209.85.160.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 24 Mar 2019 10:27:55 +0000 Received: by mail-qt1-f195.google.com with SMTP id v32so7196953qtc.10 for ; Sun, 24 Mar 2019 03:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=tTJ+eGu/FjnDv385YgZH+k8aQy9F1Mm/ilXa4n+tRgg=; b=CKlz/iTLKuFkoYnMzoopc6FSDErjtLtDPVLRInMDhNB84KY2DQObsVz1IWXpRAOJy8 xAeVxe+Wh9Q5YaUbqohnRngjGzA0yAv+At6CT0aztdqKKXy9BrR8YrheYYoLR63awG9J AVXEPRX9WBIFqEtz+Sw/YP7VzmRHsGPoOEWVERcSDWmwKcaJBi/YCWgeg3qbtQmfby7k qS9mHYZO93J+Xjqbn8KSqATLJ4cCFonC2QYN8q5cg2jP7NVDkDkWhvCLJwqga0x2tXbz CoDNKXYXuiLHZBCIOBVSR5TGujWiGw59L7RJRbjJ9X7YXbYAYQps37xb0CU72W8nGGoj IhxA== Return-Path: Received: from localhost ([2607:2200:0:2347:0:3353:62:8962]) by smtp.gmail.com with ESMTPSA id r20sm9351139qtc.48.2019.03.24.03.27.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 03:27:52 -0700 (PDT) Date: Sun, 24 Mar 2019 10:27:00 -0000 From: Konst Mayer To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC 0/8] add terminal styling to gdb Message-ID: <20190324102747.GB10967@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00514.txt.bz2 Hi! I have been very pleased to see that gdb supports colors now. Here is some feedback: - I propose to rename the 'intensity' setting to 'attributes' which among the intensity settings would support additional properties like underline, reverse, italic (other properties can be added in the future without contradicting the option name). - Support accepting numbers (in the range 0..255) in addition to names when setting foreground/background color. Thank you for your work!