From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3 6/6] Rename python function thread_from_thread_handle to thread_from_handle
Date: Thu, 21 Mar 2019 17:09:00 -0000 [thread overview]
Message-ID: <20190321100907.2ffb49f5@f29-4.lan> (raw)
In-Reply-To: <83d0mkux3f.fsf@gnu.org>
On Thu, 21 Mar 2019 16:21:40 +0200
Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Wed, 20 Mar 2019 21:51:55 -0700
> > From: Kevin Buettner <kevinb@redhat.com>
> > Cc: Eli Zaretskii <eliz@gnu.org>
> >
> > gdb/doc/ChangeLog:
> >
> > * python.texi (Inferiors In Python): Rename
> > Inferior.thread_from_thread_handle to Inferior.thread_from_handle.
> > Add note about the former being deprecated.
>
> This part is OK, with one comment:
>
> > -@findex Inferior.thread_from_thread_handle
>
> Please don't remove this index entry, it will be useful for someone
> who sees code which uses the deprecated name and wants to know what
> that is.
I was wondering about that when I made the change. I've restored the
index entry in my local sources. Here's what that part of it looks like
now:
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index 2a5a5cde3d..ab191b620c 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -2906,11 +2906,16 @@ containing the address where the pattern was found, or @code{None} if
the pattern could not be found.
@end defun
+@findex Inferior.thread_from_handle
@findex Inferior.thread_from_thread_handle
-@defun Inferior.thread_from_thread_handle (thread_handle)
-Return the thread object corresponding to @var{thread_handle}, a thread
+@defun Inferior.thread_from_handle (handle)
+Return the thread object corresponding to @var{handle}, a thread
library specific data structure such as @code{pthread_t} for pthreads
library implementations.
+
+The function @code{Inferior.thread_from_thread_handle} provides
+the same functionality, but use of @code{Inferior.thread_from_thread_handle}
+is deprecated.
@end defun
@node Events In Python
next prev parent reply other threads:[~2019-03-21 17:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 4:32 [PATCH v3 0/6] Add python method gdb.InferiorThread.handle Kevin Buettner
2019-03-21 4:42 ` [PATCH v3 1/6] Introduce target_ops method thread_info_to_thread_handle Kevin Buettner
2019-03-27 20:19 ` Tom Tromey
2019-03-21 4:45 ` [PATCH v3 2/6] Add python method InferiorThread.handle Kevin Buettner
2019-03-27 20:21 ` Tom Tromey
2019-03-21 4:46 ` [PATCH v3 3/6] Support buffer objects as handles in Inferior.thread_from_thread_handle() Kevin Buettner
2019-03-21 4:48 ` [PATCH v3 4/6] Tests for gdb.InferiorThread.handle Kevin Buettner
2019-03-21 4:49 ` [PATCH v3 5/6] Documentation for python method InferiorThread.handle Kevin Buettner
2019-03-21 14:19 ` Eli Zaretskii
2019-03-21 4:52 ` [PATCH v3 6/6] Rename python function thread_from_thread_handle to thread_from_handle Kevin Buettner
2019-03-21 14:21 ` Eli Zaretskii
2019-03-21 17:09 ` Kevin Buettner [this message]
2019-03-21 18:26 ` Eli Zaretskii
2019-03-27 20:27 ` [PATCH v3 0/6] Add python method gdb.InferiorThread.handle Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321100907.2ffb49f5@f29-4.lan \
--to=kevinb@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox