From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51695 invoked by alias); 17 Mar 2019 22:47:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51684 invoked by uid 89); 17 Mar 2019 22:47:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=automagic_dependencies, Roovers, sk:Quality, autodetection X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 22:47:26 +0000 Received: from sf (trofi-1-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:a0f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id 08EE4335D1A; Sun, 17 Mar 2019 22:47:23 +0000 (UTC) Date: Sun, 17 Mar 2019 22:47:00 -0000 From: Sergei Trofimovich To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/configure.ac: add --enable-source-highlight Message-ID: <20190317224720.181c95af@sf> In-Reply-To: <87k1h0b4ql.fsf@tromey.com> References: <20190313215020.11959-1-slyfox@gentoo.org> <87k1h0b4ql.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00360.txt.bz2 On Fri, 15 Mar 2019 08:18:42 -0600 Tom Tromey wrote: > >>>>> "Sergei" == Sergei Trofimovich writes: > > Sergei> Allow disabling source-highlight dependency autodetection even > Sergei> it exists in the system. More details on problem of automatic > Sergei> dependencies: > Sergei> https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies > > Sergei> Noticed by Jeroen Roovers in https://bugs.gentoo.org/680238 > > Hi. Thank you for the patch. > > This looks essentially fine to me. Do you have a copyright assignment > in place? (Though I wonder whether one is really needed, given that the > actual change here is pretty small.) Yes, my company has the assignment. Will resend with according email address in v2. > This probably could use some minor follow-on patches, e.g. for "show > configuration", but I'm happy to do those. I can have a stab at it as well. Anything else worth adding besides "show configuration"? I'll send v2 meanwhile. -- Sergei