From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111879 invoked by alias); 17 Mar 2019 22:28:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111871 invoked by uid 89); 17 Mar 2019 22:28:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 22:28:09 +0000 Received: from sf.home (trofi-1-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:a0f::2]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id 34E7C335D2C; Sun, 17 Mar 2019 22:28:08 +0000 (UTC) Received: by sf.home (Postfix, from userid 1000) id 3F4C7239BD874; Sun, 17 Mar 2019 22:28:05 +0000 (GMT) From: Sergei Trofimovich To: gdb-patches@sourceware.org, Tom Tromey Cc: Sergei Trofimovich Subject: [PATCH v2] gdb: unconditionally define _initialize_string_view_selftests Date: Sun, 17 Mar 2019 22:28:00 -0000 Message-Id: <20190317222731.11704-1-slyfox@gentoo.org> In-Reply-To: <20190317222004.0afa508d@sf> References: <20190317222004.0afa508d@sf> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-03/txt/msg00359.txt.bz2 From: Sergei Trofimovich The build failure was noticed by Helmut Jarausch in https://bugs.gentoo.org/680232: $ ./configure CXXFLAGS='-std=c++17 -Os' ... CXXLD gdb ld: init.o: in function `initialize_all_files()': init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()' It happens because '_initialize_string_view_selftests()' is conditionally defined based on C++ default. The change defines '_initialize_string_view_selftests()' unconditionally and leaves implementation a no-op on c++17 compilers. --- gdb/ChangeLog | 6 ++++++ gdb/unittests/string_view-selftests.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 862c89e821..7684d9be60 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-03-17 Sergei Trofimovich + + * unittests/string_view-selftests.c: define + _initialize_string_view_selftests unconditionally. This + fixes build failure on CXXFLAGS="-std=c++17" setup. + 2019-03-14 Eli Zaretskii The MS-Windows port of ncurses fails to switch to a color pair if diff --git a/gdb/unittests/string_view-selftests.c b/gdb/unittests/string_view-selftests.c index 21a10e65af..b2a2bf7f2e 100644 --- a/gdb/unittests/string_view-selftests.c +++ b/gdb/unittests/string_view-selftests.c @@ -170,10 +170,12 @@ run_tests () } /* namespace string_view */ } /* namespace selftests */ +#endif /* __cplusplus < 201703L */ + void _initialize_string_view_selftests () { +#if defined(GDB_STRING_VIEW) selftests::register_test ("string_view", selftests::string_view::run_tests); +#endif } - -#endif /* __cplusplus < 201703L */ -- 2.21.0