From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [RFC][gdb/testsuite] Fix base address selection entry encoding in dw2-skip-prologue.S
Date: Thu, 07 Mar 2019 12:11:00 -0000 [thread overview]
Message-ID: <20190307121149.GA14543@delia> (raw)
Hi,
A base address selection entry in a location list consist of two (constant or
relocated) address offsets. The two offsets are the same size as an address
on the target machine.
The test-case gdb.dwarf2/dw2-skip-prologue.S encodes a base address selection
entry using .4byte, which is incorrect for 8-byte pointer size. [ Which
triggers an assert in dwz, see PR dwz/24172. ]
Fix this by using PTRBYTE instead.
Tested on x86_64-linux.
Do we fix this type of errors in the testsuite? AFAICT, the invalid dwarf is
not intentional.
Thanks,
- Tom
[gdb/testsuite] Fix base address selection entry encoding in dw2-skip-prologue.S
gdb/testsuite/ChangeLog:
2019-03-07 Tom de Vries <tdevries@suse.de>
* gdb.dwarf2/dw2-skip-prologue.S (.debug_loc): Fix base address
selection entry encoding.
---
gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.S b/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.S
index cef6e6df12..a55699fdc6 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.S
@@ -123,7 +123,7 @@
.section .debug_loc
loclist:
/* Reset the location list base address first. */
- .4byte -1, 0
+ PTRBYTE -1, 0
PTRBYTE func_start, func_end
.2byte 2f-1f
next reply other threads:[~2019-03-07 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 12:11 Tom de Vries [this message]
2019-04-23 14:21 ` [PING][RFC][gdb/testsuite] " Tom de Vries
2019-05-07 14:50 ` [PING^2][RFC][gdb/testsuite] " Tom de Vries
2019-05-14 6:53 ` [PING^3][RFC][gdb/testsuite] " Tom de Vries
2019-05-14 8:04 ` [RFC][gdb/testsuite] " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307121149.GA14543@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox