From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115486 invoked by alias); 5 Mar 2019 18:52:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115473 invoked by uid 89); 5 Mar 2019 18:52:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:2019030 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Mar 2019 18:52:00 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8C21CC057F50; Tue, 5 Mar 2019 18:51:59 +0000 (UTC) Received: from f29-4.lan (ovpn-117-11.phx2.redhat.com [10.3.117.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FA1260DB4; Tue, 5 Mar 2019 18:51:59 +0000 (UTC) Date: Tue, 05 Mar 2019 18:52:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH] Small fix to gdb.Value constructor doc Message-ID: <20190305115158.13376d15@f29-4.lan> In-Reply-To: <20190305170544.23216-1-simon.marchi@efficios.com> References: <20190305170544.23216-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00065.txt.bz2 On Tue, 5 Mar 2019 12:05:44 -0500 Simon Marchi wrote: > The synopsis of the two-parameters form of the gdb.Value constructor is > currently shown as > > Value.__init__ (val, [, type ]) > > in the documentation. > > First, there is an extra comma, which I think we can remove in any > case. > > Then, since the type parameter is not optional, I would not put in > between square brackets. Those usually indicate that something is > optional. > > With this patch, it appears as: > > Value.__init__ (val, type) I agree with your changes. Thanks for fixing this! Kevin