From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154361-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 130150 invoked by alias); 4 Mar 2019 23:30:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 130140 invoked by uid 89); 4 Mar 2019 23:30:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:467, H*MI:sk:2019030
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 23:30:50 +0000
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 54F3F3082AEE;	Mon,  4 Mar 2019 23:30:49 +0000 (UTC)
Received: from f29-4.lan (ovpn-117-11.phx2.redhat.com [10.3.117.11])	by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D4116085B;	Mon,  4 Mar 2019 23:30:49 +0000 (UTC)
Date: Mon, 04 Mar 2019 23:30:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 2/2] Make null_ptid and minus_one_ptid "const"
Message-ID: <20190304163048.5ef186ef@f29-4.lan>
In-Reply-To: <20190304202516.19100-3-tromey@adacore.com>
References: <20190304202516.19100-1-tromey@adacore.com>	<20190304202516.19100-3-tromey@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-03/txt/msg00049.txt.bz2

On Mon,  4 Mar 2019 13:25:16 -0700
Tom Tromey <tromey@adacore.com> wrote:

> This makes null_ptid and minus_one_ptid "const".  I think this is an
> improvement because it means they can't be accidentally modified.
> 
> xgdb/ChangeLog
> 2019-03-04  Tom Tromey  <tromey@adacore.com>
> 
> 	* common/ptid.c (null_ptid, minus_one_ptid): Now const.
> 	* common/ptid.h (null_ptid, minus_one_ptid): Now const.

LGTM.

Kevin