From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14613 invoked by alias); 4 Mar 2019 11:15:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14599 invoked by uid 89); 4 Mar 2019 11:15:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=fedora, pre-release, prerelease, gdb8290 X-HELO: mail-wr1-f51.google.com Received: from mail-wr1-f51.google.com (HELO mail-wr1-f51.google.com) (209.85.221.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 11:14:59 +0000 Received: by mail-wr1-f51.google.com with SMTP id w6so5073413wrs.4 for ; Mon, 04 Mar 2019 03:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KxJ0xj5M9qEjbqHgzfr3CPnBwSmtGciMSSZ3lrSiX8c=; b=I5jSkzz+qt2y4JRccBF5Nvbgt+i8ZrX4yYL9z6/ys9Ju96d3voMaqTw49J8AdB79AF 1VWljOoR9c31KwPi1zCjyu9zBriwI571GzEaM2pjqbOXWVWWJj5RKjXZ1nQKQNexOJWc q82TVxPULf2ioXo9ZvCcLuOBi2X62jSLY1BIB9BPtCvHdQ6zItTpHKnAKJcT2EiyPnM+ Il720EHC0B0YwfGjvKkidK/eSkjL3ZXhFrmKz4JrxHP0KVXdScg5hGD0dezJwkJ0qKsK cbQ893lylHqPsmQAX78LFXjeAUijFV7OcHuVmiT2W75YEjTzBKi2zvbb6/NvD9+KkJuN 0rlA== Return-Path: Received: from localhost (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by smtp.gmail.com with ESMTPSA id o5sm4673281wmh.12.2019.03.04.03.14.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 03:14:56 -0800 (PST) Date: Mon, 04 Mar 2019 11:15:00 -0000 From: Andrew Burgess To: Jim Wilson Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: GDB 8.2.90 available for testing Message-ID: <20190304111454.GV10887@embecosm.com> References: <20190227055112.4A5E782D7B@joel.gnat.com> <332e186f-0c04-ab6d-754e-bf14d2981923@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <332e186f-0c04-ab6d-754e-bf14d2981923@sifive.com> X-Fortune: Before I knew the best part of my life had come, it had gone. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00026.txt.bz2 * Jim Wilson [2019-02-27 14:05:23 -0800]: > On 2/26/19 9:51 PM, Joel Brobecker wrote: > > I have just finished creating the gdb-8.2.90 pre-release. > > Please give it a test if you can and report any problems you might find. > > On a riscv64-linux system (HiFive Unleashed w/ Fedora Core 29), without an > Ada compiler in my path, I get > > === gdb Summary === > > # of expected passes 50264 > # of unexpected failures 2297 > # of expected failures 57 > # of unknown successes 3 > # of known failures 79 > # of untested testcases 132 > # of unresolved testcases 110 > # of unsupported tests 359 > > which looks OK. There was no riscv-linux native support in gdb-8.2 so this > is a major improvement over the last one. I did used to have better results > though. I'm seeing > > hifiveu017:1040$ grep ^FAIL gdb.sum | grep infcall | wc > 878 8059 103059 > > and I think that these mostly used to work, since I used to have about 1500 > failures. I think something in the last 3 months broke this, but I haven't > had time to track it down. I see stuff like this in the log files > > p/d check_arg_struct_01_01 (ref_val_struct_01_01)^M > ../../binutils-gdb/gdb/riscv-tdep.c:2119: internal-error: void > riscv_call_arg_struct(riscv_arg_info*, riscv_call_info*): Assertion > `TYPE_LENGTH (ainfo->type) == TYPE_LENGTH (sinfo.field_type (0))' failed.^M > A problem internal to GDB has been detected,^M > further debugging may prove unreliable.^M > Quit this debugging session? (y or n) FAIL: > gdb.base/infcall-nested-structs.exp: l=c++: types-tfc: p/d > check_arg_struct_01_01 (ref_val_struct_01_01) (GDB internal error) I don't think these are regressions, just new tests that expose a bug that was present since the initial upstreaming. The issue relates to the difference in size between an empty struct in gcc and g++ (0 vs 1 respectively), and how this effects argument passing. I have a fix in progress, but it will probably be a couple of days before its ready to post. I guess we can back-port to 8.3 if I get the patch ready soon. I'm not too worried if it doesn't make it in though, if feels like an edge case. Thanks, Andrew