Re: [RFC 09/17] Introduce async-event.[ch]

Tom Tromey
2019-10-04T22:17:48Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 2/24/19 4:51 PM, Tom Tromey wrote:
>> This patch splits out some gdb-specific code from event-loop, into new
>> files async-event.[ch]. Strictly speaking this code could perhaps be
>> put into common/, but because gdbserver does not currently use it, it
>> seemed better, for size reasons, to split it out.

Pedro> Seems fine. Going forward, I wonder whether we'll split event loop
Pedro> things into more files, and whether using a name prefix like "event-loop-"
Pedro> or "el-", like "el-async-event.[ch]" would help keeping things a bit
Pedro> closer together. Just a thought; not a request.

I don't have plans to do anything more in this area, and I didn't feel
quite strongly enough about it to do the renaming, so I've just left it
as-is.

I somewhat wish we could remove all this code in favor of a pre-canned
event loop solution, like libevent. Too bad dependencies are such a
pain.

Tom