From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79850 invoked by alias); 17 Feb 2019 13:34:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79841 invoked by uid 89); 17 Feb 2019 13:34:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=forcing, wrapped, Forcing, hijack X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Feb 2019 13:34:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6B7BA56057; Sun, 17 Feb 2019 08:34:02 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qPOlP5XKjKES; Sun, 17 Feb 2019 08:34:02 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 08B5356055; Sun, 17 Feb 2019 08:34:02 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 857DB838C7; Sun, 17 Feb 2019 17:33:57 +0400 (+04) Date: Sun, 17 Feb 2019 13:34:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] (Ada) fix GDB crash printing packed array Message-ID: <20190217133357.GD25164@adacore.com> References: <1549786901-77868-1-git-send-email-brobecker@adacore.com> <87mumwzvad.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mumwzvad.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-02/txt/msg00268.txt.bz2 > Joel> (1) Forcing the lookup into language_c currently does not affect > Joel> how symbol matching is done anymore, because we look at the symbol's > Joel> language to determine which kind of matching should be done; > > There's also this code in get_symbol_name_matcher: > > /* If currently in Ada mode, and the lookup name is wrapped in > '<...>', hijack all symbol name comparisons using the Ada > matcher, which handles the verbatim matching. */ > if (current_language->la_language == language_ada > && lookup_name.ada ().verbatim_p ()) > return current_language->la_get_symbol_name_matcher (lookup_name); > > I don't know if this could be removed, but if so it would be better to > do so. I was absolutely certain, looking at the new code, that we could remove this, but unfortunately, it turns out there is a regression. Before removing: (gdb) p $1 = void^M After: (gdb) p $1 = {} 0x4029c6 This tells me that the function symbol wasn't found (in the debuging info), so we used the minsym instead. Not sure if this is because the verbatim_p flag might be missing, or because of something else. We'll put this on our list of things to investigate, one of these days. > The patch looks fine to me. Thanks! Now pushed to master. -- Joel