From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Fix pager bugs with style output
Date: Thu, 14 Feb 2019 03:34:00 -0000 [thread overview]
Message-ID: <20190214033432.GC2945@adacore.com> (raw)
In-Reply-To: <87sgwt6ik4.fsf@tromey.com>
> Andrew> I don't have a solution, but the issue here is that in
> Andrew> user_select_syms output is produced with printf_unfiltered, by passing
> Andrew> the line wrapping buffer, however, the symbol name is produced by a
> Andrew> call to ada_print_symbol_signature which uses fprintf_filtered,
> Andrew> placing the output into the line wrap buffer.
>
> Thanks for looking into this.
>
> Andrew> You'll need to reconcile these two things.
>
> Andrew> Given that ada_print_symbol_signature only seems to be called in areas
> Andrew> that are using unfiltered printing, simply changing
> Andrew> ada_print_symbol_signature to also use unfiltered printing should
> Andrew> provide a solution.
>
> How about having user_select_syms also use filtered output?
> That seems like it would be somewhat friendlier in the unlikely event
> that the menu was very long -- it would give the user a chance to read
> the choices.
I think it makes sense, especially now that you enhanced the paging
to allow us to print everything without being asked about paging
anymore. It should be fairly easy to revert back if we find that
this is causing unforseen problems.
--
Joel
next prev parent reply other threads:[~2019-02-14 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 18:37 Tom Tromey
2019-02-10 12:38 ` Joel Brobecker
2019-02-12 13:53 ` Andrew Burgess
2019-02-12 17:08 ` Tom Tromey
2019-02-14 3:34 ` Joel Brobecker [this message]
2019-02-12 17:13 ` Tom Tromey
2019-02-12 18:22 ` Tom Tromey
2019-02-17 12:31 ` Joel Brobecker
2019-02-17 15:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214033432.GC2945@adacore.com \
--to=brobecker@adacore.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox