From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48330 invoked by alias); 3 Feb 2019 17:45:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48252 invoked by uid 89); 3 Feb 2019 17:45:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 03 Feb 2019 17:45:41 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B3488C0C9A8B; Sun, 3 Feb 2019 17:45:40 +0000 (UTC) Received: from f29-4.lan (ovpn-116-80.phx2.redhat.com [10.3.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D319600C1; Sun, 3 Feb 2019 17:45:40 +0000 (UTC) Date: Sun, 03 Feb 2019 17:45:00 -0000 From: Kevin Buettner To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp Message-ID: <20190203104539.6272f9d8@f29-4.lan> In-Reply-To: <20190126223435.9411-1-philippe.waroquiers@skynet.be> References: <20190126223435.9411-1-philippe.waroquiers@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00012.txt.bz2 On Sat, 26 Jan 2019 23:34:35 +0100 Philippe Waroquiers wrote: > include/ChangeLog > 2019-01-26 Philippe Waroquiers > > * splay-tree.h (splay_tree_delete_key_fn): Update comment. > (splay_tree_delete_value_fn): Likewise. > > libiberty/ChangeLog > 2019-01-26 Philippe Waroquiers > > * splay-tree.c (splay_tree_insert): Also release old KEY in case > of insertion of a key equal to an already present key. > (splay_tree_new_typed_alloc): Update comment. These changes look reasonable to me, BUT... I think you'll need to get approval for this patch from the gcc maintainers. The libiberty README file indicates that fixes should be sent to gcc-patches@gcc.gnu.org. Kevin