Re: [PATCH] [PowerPC] Aliases for vector registers

Ulrich Weigand
2019-01-14T14:03:23Z

Pedro Franco de Carvalho wrote:

> gdb/ChangeLog:
> 2019-01-10 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
> field.
> * rs6000-tdep.c: Include reggroups.h.
> (IS_V_ALIAS_PSEUDOREG): Define.
> (rs6000_register_name): Return names for the "vX" aliases.
> (rs6000_pseudo_register_type): Return type for the "vX" aliases.
> (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
> aliases. Call default_register_reggroup_p for all other
> pseudo-registers.
> (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
> New functions.
> (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
> Handle "vX" aliases.
> (v_alias_pseudo_register_collect): New function.
> (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
> (rs6000_gdbarch_init): Initialize "vX" aliases as
> pseudo-registers. Restore registration of
> rs6000_pseudo_register_reggroup_p with
> set_tdesc_pseudo_register_reggroup_p.
>
> gdb/testsuite/ChangeLog:
> 2019-01-10 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * gdb.arch/vsx-regs.exp: Add tests that use the vector register
> aliases.
> * gdb.arch/altivec-regs.exp: Likewise. Fix indentation of two
> tests.
> * gdb.arch/powerpc-vector-regs.c: New file.
> * gdb.arch/powerpc-vector-regs.exp: New file.

This is OK.

Thanks,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com