From: Andrey Utkin <autkin@undo.io>
To: gdb-patches@sourceware.org
Cc: Andrey Utkin <autkin@undo.io>
Subject: [PATCH] Handle hitting a recording extent boundary as a normal trap-caused stop
Date: Fri, 04 Jan 2019 21:38:00 -0000 [thread overview]
Message-ID: <20190104213758.3477-1-autkin@undo.io> (raw)
Because that's what it is.
This enables reporting of a breakpoint hitting on the first replayable
instruction when reverse-stepping to the beginning of recorded history.
---
gdb/infrun.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 150288264f..a72f06129b 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -5212,11 +5212,12 @@ Cannot fill $_exitsignal with the correct signal number.\n"));
ecs->event_thread->suspend.stop_pc
= regcache_read_pc (get_thread_regcache (inferior_thread ()));
- if (handle_stop_requested (ecs))
- return;
-
gdb::observers::no_history.notify ();
- stop_waiting (ecs);
+
+ // The end of history is always a stop after a stepping/running op
+ ecs->ws.kind = TARGET_WAITKIND_STOPPED;
+ ecs->ws.value.sig = GDB_SIGNAL_TRAP;
+ handle_signal_stop (ecs);
return;
}
}
--
2.16.4
next reply other threads:[~2019-01-04 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 21:38 Andrey Utkin [this message]
2019-01-07 16:07 ` Andrey Utkin
2019-01-17 15:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104213758.3477-1-autkin@undo.io \
--to=autkin@undo.io \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox