Re: [RFA] Fix 'Invalid read of size 4' in search_command_helper

Philippe Waroquiers
2019-01-01T19:35:58Z

On Tue, 2019-01-01 at 11:37 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
>
> Philippe> gdb/ChangeLog
> Philippe> 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> Philippe> * source.c (search_command_helper): Stop reverse search
> Philippe> when line 1 has been searched.
>
> This is ok. Some of these could probably have gone in under the obvious
> rule, though I completely understand if you'd rather not do that.
Effectively, some fixes are easy enough to be obvious, but still sometimes
an explicit review helps to see e.g. when it is time to restructure
the code (e.g. to restructure it using c++).

Thanks for the reviews, I pushed all 3 RFA fixes.

Philippe