From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6302 invoked by alias); 28 Dec 2018 10:09:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6279 invoked by uid 89); 28 Dec 2018 10:09:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Dec 2018 10:09:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 988D41173AA; Fri, 28 Dec 2018 05:09:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mgCD8BV91XGd; Fri, 28 Dec 2018 05:09:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3A85D11702F; Fri, 28 Dec 2018 05:09:53 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C909986754; Fri, 28 Dec 2018 14:09:48 +0400 (+04) Date: Fri, 28 Dec 2018 10:09:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: GDB internal error in pc_in_thread_step_range Message-ID: <20181228100948.GI21851@adacore.com> References: <659d33b5e4af35aea6c3aaef08559f31@polymtl.ca> <837eg4cick.fsf@gnu.org> <988ca92d2c5c976fbea57c2381eb6279@polymtl.ca> <834lb6ar3g.fsf@gnu.org> <83sgyo8brg.fsf@gnu.org> <83k1jy9a2k.fsf@gnu.org> <1ebc24f4-9b09-4a42-6b24-f43f6641eb9d@polymtl.ca> <837efu6sby.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <837efu6sby.fsf@gnu.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00383.txt.bz2 > > >>> --- gdb/coffread.c~1 2018-07-04 18:41:59.000000000 +0300 > > >>> +++ gdb/coffread.c 2018-12-23 10:24:15.758116900 +0200 > > >>> @@ -874,8 +874,10 @@ coff_symtab_read (minimal_symbol_reader > > >>> int section = cs_to_section (cs, objfile); > > >>> > > >>> tmpaddr = cs->c_value; > > >>> - record_minimal_symbol (reader, cs, tmpaddr, mst_text, > > >>> - section, objfile); > > >>> + /* Don't record unresolved symbols. */ > > >>> + if (!(cs->c_secnum <= 0 && cs->c_value == 0)) > > >>> + record_minimal_symbol (reader, cs, tmpaddr, mst_text, > > >>> + section, objfile); > > >>> > > >>> fcn_line_ptr = main_aux.x_sym.x_fcnary.x_fcn.x_lnnoptr; > > >>> fcn_start_addr = tmpaddr; > > >> > > >> That looks good to me. > > > > > > Should I push it to the master branch? > > > > Yes, just make sure to include the relevant info in the commit log. > > It would be a good idea to link back to this thread, so someone doing > > archeology can find why we added this. > > Done. > > Thanks for your help with investigating this issue and with finding > the right solution for it. FWIW, I ran this patch through AdaCore's testsuite, on both x86 and x86_64 Windows, and detected do regressions. -- Joel