From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53471 invoked by alias); 26 Dec 2018 15:27:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53462 invoked by uid 89); 26 Dec 2018 15:27:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Dec 2018 15:27:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 37A79116447; Wed, 26 Dec 2018 10:27:50 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id x3Nk1-q2P1lC; Wed, 26 Dec 2018 10:27:50 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B04A6116441; Wed, 26 Dec 2018 10:27:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4B15986753; Wed, 26 Dec 2018 19:27:43 +0400 (+04) Date: Wed, 26 Dec 2018 15:27:00 -0000 From: Joel Brobecker To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFAv2 2/4] Fix gdb.ada/rename_subscript_param.exp by using more unique names. Message-ID: <20181226152743.GD21851@adacore.com> References: <20181226140304.19594-1-philippe.waroquiers@skynet.be> <20181226140304.19594-3-philippe.waroquiers@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181226140304.19594-3-philippe.waroquiers@skynet.be> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00331.txt.bz2 On Wed, Dec 26, 2018 at 03:03:02PM +0100, Philippe Waroquiers wrote: > The test fails due to conflict between boolean 'b'and some 'b' in atnat.h: > > (gdb) print b > Multiple matches for b > [0] cancel > [1] b at ../sysdeps/ieee754/dbl-64/atnat.h:106 > [2] b at ../sysdeps/ieee754/dbl-64/atnat.h:106 > [3] b at ../sysdeps/ieee754/dbl-64/atnat.h:106 > > FAIL: gdb.ada/rename_subscript_param.exp: print b before changing its value (timeout) > > Fix by renaming 'b' to 'rename_subscript_param_b. To me, the way this patch is explained is a little misleading ("the fix"). I would explain instead why you are getting this multiple-choice question, and why you are electing to rename the entity... > Also, change 'before' to 'after' in the gdb_test message that prints > the value after changing it. > The test however still fails for me, probably because the Debian stable > Ada compiler is too old, and does not properly generate debug info for > this renamining: > (gdb) print rename_subscript_param_b > No definition of "rename_subscript_param_b" in current context. > (gdb) FAIL: gdb.ada/rename_subscript_param.exp: print rename_subscript_param_b before changing its value > > Note: if the compiler would generate the correct debug info, the test should > succeed with the name B. However, waiting for this fix, changing the name > ensures that the test fails directly, instead of causing a timeout. > > 2018-12-26 Philippe Waroquiers > > * gdb.ada/rename_subscript_param/pkg.adb (B): Rename to > Rename_Subscript_Param_B. All users updated. The patch itself looks good, though. -- Joel