From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12922 invoked by alias); 24 Dec 2018 09:27:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12911 invoked by uid 89); 24 Dec 2018 09:27:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=console, will!, alien, refresh X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Dec 2018 09:27:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7420D11712A; Mon, 24 Dec 2018 04:27:43 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ryJRMYznfnwA; Mon, 24 Dec 2018 04:27:43 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D30C11170E1; Mon, 24 Dec 2018 04:27:42 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 33BEA86756; Mon, 24 Dec 2018 13:27:35 +0400 (+04) Date: Mon, 24 Dec 2018 09:27:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI Message-ID: <20181224092735.GL5246@adacore.com> References: <20181128001435.12703-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181128001435.12703-1-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00296.txt.bz2 > This patch series adds terminal styling (colorizing) to gdb's CLI and > TUI. It is a refresh of an earlier RFC series, but some parts have > changed, and now there are tests and documentation. It also includes > some TUI colorizing patches that were sent separately. > > This series doesn't support the Windows console. I don't know > anything about it. So, it defaults to disabling styling on Windows > hosts. This could be fixed by doing something like what the TUI does: > filter escape sequences from the output and apply them by some other > means. > > More styling could be done. It's relatively easy to add a new > style-able object. > > If you want to try this out, it is the branch "submit/colorize" in my > github repository. > > Regression tested on x86-64 Fedora 28. I think it was too big for the > buildbot. I gave the whole series a look. The TUI changes were a bit alien to me. I sent comments on the patches where I had questions; otherwise, those I didn't comment on looked fine to me. I really look forward to this series making it to master, it would be a nice feature to advertise on the release that includes it. The source highlighting is also a very nice touch! One feature I might volunteer to work on once the series is in is to provide two sets of defaults for the colors - one to be used when the terminal has a dark background vs one to be used when the terminal has a light background. I think the way ou added colorizing should make it easy to do. That's all I had to say as a summary. Thanks a lot for those. I think people are going to enjoy this enchancement. At least I know I will! -- Joel