From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70476 invoked by alias); 24 Dec 2018 02:56:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70465 invoked by uid 89); 24 Dec 2018 02:56:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=evil, twin X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Dec 2018 02:56:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D484C11711A; Sun, 23 Dec 2018 21:56:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rOjHInVHQvlO; Sun, 23 Dec 2018 21:56:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 711B9117114; Sun, 23 Dec 2018 21:56:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A2F1786756; Mon, 24 Dec 2018 06:56:42 +0400 (+04) Date: Mon, 24 Dec 2018 02:56:00 -0000 From: Joel Brobecker To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix gdb.ada bp_fun_addr failure due to conflict between fun 'a' and s-dimmks.ads 'A'. Message-ID: <20181224025642.GF5246@adacore.com> References: <20181223202308.31611-1-philippe.waroquiers@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181223202308.31611-1-philippe.waroquiers@skynet.be> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00290.txt.bz2 Hi Philippe, On Sun, Dec 23, 2018 at 09:23:08PM +0100, Philippe Waroquiers wrote: > The test fails (timeout) due to: > (gdb) PASS: gdb.ada/bp_fun_addr.exp: break *a'address > run > Starting program: /bd/home/philippe/gdb/git/build_info_t/gdb/testsuite/outputs/gdb.ada/bp_fun_addr/a > Multiple matches for a > [0] cancel > [1] a at /bd/home/philippe/gdb/git/info_t/gdb/testsuite/gdb.ada/bp_fun_addr/a.adb:18 > [2] system.dim.mks.a at s-dimmks.ads:115 > > FAIL: gdb.ada/bp_fun_addr.exp: run until breakpoint at a'address (timeout) Ah, my evil twin was so naive, back then... > testcase /home/philippe/gdb/git/build_info_t/gdb/testsuite/../../../info_t/gdb/testsuite/gdb.ada/bp_fun_addr.exp completed in 10 seconds > > Fix this by using a fun name that has more chances to be unique. > > 2018-12-23 Philippe Waroquiers > > * gdb.ada/bp_fun_addr/a.adb (a): Rename to bp_fun_addr. > Filename a.adb changed to bp_fun_addr.adb. > gdb.ada/bp_fun_addr.exp: Update test accordingly. Thank you for the patch. This is OK. > --- > gdb/testsuite/gdb.ada/bp_fun_addr.exp | 10 +++++----- > .../gdb.ada/bp_fun_addr/{a.adb => bp_fun_addr.adb} | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > rename gdb/testsuite/gdb.ada/bp_fun_addr/{a.adb => bp_fun_addr.adb} (94%) > > diff --git a/gdb/testsuite/gdb.ada/bp_fun_addr.exp b/gdb/testsuite/gdb.ada/bp_fun_addr.exp > index b037d43538..38a2609677 100644 > --- a/gdb/testsuite/gdb.ada/bp_fun_addr.exp > +++ b/gdb/testsuite/gdb.ada/bp_fun_addr.exp > @@ -17,7 +17,7 @@ load_lib "ada.exp" > > if { [skip_ada_tests] } { return -1 } > > -standard_ada_testfile a > +standard_ada_testfile bp_fun_addr > > if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} { > return -1 > @@ -25,11 +25,11 @@ if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} { > > clean_restart ${testfile} > > -gdb_test "break *a'address" \ > - "Breakpoint \[0-9\]+ at.*: file .*a.adb, line \[0-9\]+." > +gdb_test "break *bp_fun_addr'address" \ > + "Breakpoint \[0-9\]+ at.*: file .*bp_fun_addr.adb, line \[0-9\]+." > > gdb_run_cmd > gdb_test "" \ > - "Breakpoint $decimal, a \\(\\).*" \ > - "run until breakpoint at a'address" > + "Breakpoint $decimal, bp_fun_addr \\(\\).*" \ > + "run until breakpoint at bp_fun_addr'address" > > diff --git a/gdb/testsuite/gdb.ada/bp_fun_addr/a.adb b/gdb/testsuite/gdb.ada/bp_fun_addr/bp_fun_addr.adb > similarity index 94% > rename from gdb/testsuite/gdb.ada/bp_fun_addr/a.adb > rename to gdb/testsuite/gdb.ada/bp_fun_addr/bp_fun_addr.adb > index 00e2e86355..2faf6da843 100644 > --- a/gdb/testsuite/gdb.ada/bp_fun_addr/a.adb > +++ b/gdb/testsuite/gdb.ada/bp_fun_addr/bp_fun_addr.adb > @@ -13,7 +13,7 @@ > -- You should have received a copy of the GNU General Public License > -- along with this program. If not, see . > > -procedure A is > +procedure Bp_Fun_Addr is > begin > null; > -end A; > +end Bp_Fun_Addr; > -- > 2.19.2 -- Joel