From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75465 invoked by alias); 20 Dec 2018 07:57:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75446 invoked by uid 89); 20 Dec 2018 07:57:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=occasional, diverse, his X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Dec 2018 07:57:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A621256190; Thu, 20 Dec 2018 02:57:34 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TGFF+Jwldw5E; Thu, 20 Dec 2018 02:57:34 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2441F5618D; Thu, 20 Dec 2018 02:57:34 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 685CD83D5A; Thu, 20 Dec 2018 11:57:28 +0400 (+04) Date: Thu, 20 Dec 2018 07:57:00 -0000 From: Joel Brobecker To: Philippe Waroquiers Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA] Ensure deterministic result order in gdb.ada/info_auto_lang.exp Message-ID: <20181220075728.GC12440@adacore.com> References: <20181201133810.9542-1-philippe.waroquiers@skynet.be> <1545255361.2974.2.camel@skynet.be> <20181220052958.GB12440@adacore.com> <1545286359.2974.9.camel@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545286359.2974.9.camel@skynet.be> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00232.txt.bz2 > Simon/Joel, thanks for the help, I see everyday that I am far to > master the gdb subtleties :). Please point me in the direction of someone who knows them all.. ;-) > On Thu, 2018-12-20 at 00:50 -0500, Simon Marchi wrote: > > On 2018-12-20 00:29, Joel Brobecker wrote: > ... > > > However, if you configure using a relative path to the configure > > > script, > > > things become different. > Effectively, I am building and testing out-of-tree, but with a relative > configure => I will change to use an absolute configure path. I don't think you have to, and from my perspective, I don't see why it should be a requirement. > > Then, I think it makes sense to normalize the paths in order to have a > > predictable output, regardless of how gdb was configured, as Philippe > > suggested. Are you also ok with his patch? > > And if ok, do we better do standard_csrcfile_for_ada used for all such > c files used by gdb.ada, or do we limit the normalization to this test > ? I don't have a strong opinion. I don't see a compelling reason to do the normalization systematically at the moment, as perhaps it gives us more diverse testing coverage. The cost is indeed those occasional testcases that fail for some but not others. I don't know if we expect this to happen so often that we need to make it systematic. I would personally start with your patch, and adjust later, if it turns out we have enough testcases facing that issue. And for the avoidance of doubt, and not hold the patch waiting for me, your patch looks good to me. -- Joel