From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100607 invoked by alias); 20 Dec 2018 05:31:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99962 invoked by uid 89); 20 Dec 2018 05:30:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:1545255, H*i:sk:1545255, act X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Dec 2018 05:30:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AB7E956181; Thu, 20 Dec 2018 00:30:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pGNVlQfLSbZW; Thu, 20 Dec 2018 00:30:05 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id ED3E756124; Thu, 20 Dec 2018 00:30:04 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9C5A383D5A; Thu, 20 Dec 2018 09:29:58 +0400 (+04) Date: Thu, 20 Dec 2018 05:31:00 -0000 From: Joel Brobecker To: Philippe Waroquiers Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA] Ensure deterministic result order in gdb.ada/info_auto_lang.exp Message-ID: <20181220052958.GB12440@adacore.com> References: <20181201133810.9542-1-philippe.waroquiers@skynet.be> <1545255361.2974.2.camel@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545255361.2974.2.camel@skynet.be> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00229.txt.bz2 > > Since both paths appear already normalized in my case, the test does fails for me and your patch > > would fix it. I am 99% sure I am fine with your fix, I just want to make sure we are on the same > > page. > A mystery to me why paths are already normalized in your build ... > What compilation command do you see in the gdb.log for some_c.c ? I think it depends how you configure your build, and where you do your testing. That's why Simon asked you about it. Personally, I build and test out-of-tree, and this is the recommended way. And the second important element is the fact that I use an absolute path to the configure script: $ cd /path/to/build $ /path/to/src/configure [...] $ make When you configure GDB that way, then the testsuite framework will compile the C files by passing the absolute path to those C files. For instance on example from my gdb.log file: | Executing on host: gcc [...] -c -g [snip snip] /path/to/src/gdb/testsuite/gdb.base/gdb1090.c (timeout = 300) However, if you configure using a relative path to the configure script, things become different. With the same example, but configured using... $ cd /path/to/build $ ../src/configure [...] ... the path given by the testsuite frame to GCC in order to compile C files now includes these relative directory adjustments you are seeing. Eg: | Executing on host: gcc [...] -c -g [...] /path/to/bld/gdb/testsuite/../../../../act/gdb-public/gdb/testsuite/gdb.base/gdb1090.c (timeout = 300) Whether it must be this way or not and why, I don't know. But I don't think it's even worth exploring the idea of changing it. -- Joel