From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5307 invoked by alias); 12 Dec 2018 17:40:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5208 invoked by uid 89); 12 Dec 2018 17:40:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:800, HX-Gm-Message-State:aEWZ8 X-HELO: mail-wr1-f50.google.com Received: from mail-wr1-f50.google.com (HELO mail-wr1-f50.google.com) (209.85.221.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Dec 2018 17:40:51 +0000 Received: by mail-wr1-f50.google.com with SMTP id t27so18551173wra.6 for ; Wed, 12 Dec 2018 09:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ang5v+hmEJbk/f9m+V/3NF/ss7OjzmAP54c37pby064=; b=IJH4IXZPcpEvRU0wVu3m2GIBOGeXh8IX6hLbvcmX0eWmsOW4Lt6H+1cCVvFp6cROxs AQd/Xp94AHck9+14s+3HFfd9fN7UhqXxmJhNvCDISVb9fgnKE20qm5HolAHF5J5vuBIF Vxa5hgui+oZDeABI4NK8yz+a6UmJm0SYKPpb55cC7J+897gqCkwyS1390Vm01i7bl6O5 nuw2k6ZTrLEm3VI37pAYAdlyne48LZpsFs+29l5rGIZDErSNzi737DtcWeTvSI1Eevms rxXsfcm3aVmCoTnsFNVsw2ZSPHdEuWImxiQNnITqA3vU4ShDTbMQJZh1RhjHHNRq+qSs O+JA== Return-Path: Received: from localhost ([2a02:390:741d:1:3665:d267:b319:d766]) by smtp.gmail.com with ESMTPSA id y13sm20311653wrw.85.2018.12.12.09.40.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Dec 2018 09:40:48 -0800 (PST) Date: Wed, 12 Dec 2018 17:40:00 -0000 From: Andrew Burgess To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 0/2] Handle Errors While Preparing For Inferior Call Message-ID: <20181212174046.GL18841@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: Half a mind is a terrible thing to waste! X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00139.txt.bz2 * Pedro Alves [2018-12-12 16:14:45 +0000]: > On 12/12/2018 03:16 PM, Andrew Burgess wrote: > > This revision doesn't change much over v2, except that I have dropped > > the previous patch #2 in response to Pedro's feedback. > > > > I still think that patch #1 is worth while, it _is_ possible to throw > > errors while reading registers, and ideally this wouldn't cause an > > assertion (which with patch #1 it no longer will). > > > > What is now patch #2, but was previously #3 is just a small cleanup of > > test results. > > Sorry for the delay, I did not intend to block this. I've reviewed > the patches now. Absolutely not a problem. Thanks for the review. Pushed with the fixes you identified. Andrew