From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27917 invoked by alias); 28 Nov 2018 00:14:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27719 invoked by uid 89); 28 Nov 2018 00:14:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=m*, Reading X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.29) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Nov 2018 00:14:42 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id CBC33E4ED for ; Tue, 27 Nov 2018 18:14:40 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id RnV2g8QmPSjJARnV2gVvL9; Tue, 27 Nov 2018 18:14:40 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5918uxNkWw/N3913RnEFFC/ZZ1YXP1jyNykUPfdl/VE=; b=HCbCIVmyV0Zu4cBLUbmMEAKKPM 4e3KCtsfEC8YgqmXU7GFjpJYCjowmmP5hS4NahHKkQNFFB0WhHmZq2OmdGYhL4JiOiUDe/ye8K2EF pG8DhyoGkj0lX3KiyKLI7GqOD; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:33804 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gRnV2-004MMp-KD; Tue, 27 Nov 2018 18:14:40 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 11/16] Style the "Reading symbols" message Date: Wed, 28 Nov 2018 00:16:00 -0000 Message-Id: <20181128001435.12703-12-tom@tromey.com> In-Reply-To: <20181128001435.12703-1-tom@tromey.com> References: <20181128001435.12703-1-tom@tromey.com> X-SW-Source: 2018-11/txt/msg00507.txt.bz2 The "Reading symbols" message does not use ui-out (perhaps it should?), so this styles it using the low-level API. gdb/ChangeLog 2018-11-27 Tom Tromey * symfile.c (symbol_file_add_with_addrs): Style file name. gdb/testsuite/ChangeLog 2018-11-27 Tom Tromey * gdb.base/style.exp: Add test for styling of "Reading symbols" message. --- gdb/ChangeLog | 4 ++++ gdb/symfile.c | 7 ++++++- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/style.exp | 4 ++++ 4 files changed, 19 insertions(+), 1 deletion(-) diff --git a/gdb/symfile.c b/gdb/symfile.c index 8ab6a25de7..b5d888ee2b 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -58,6 +58,7 @@ #include "cli/cli-utils.h" #include "common/byte-vector.h" #include "selftest.h" +#include "cli/cli-style.h" #include #include @@ -1110,7 +1111,11 @@ symbol_file_add_with_addrs (bfd *abfd, const char *name, if (deprecated_pre_add_symbol_hook) deprecated_pre_add_symbol_hook (name); else - printf_filtered (_("Reading symbols from %s...\n"), name); + { + puts_filtered (_("Reading symbols from ")); + fputs_styled (name, file_name_style.style (), gdb_stdout); + puts_filtered ("...\n"); + } } syms_from_objfile (objfile, addrs, add_flags); diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp index a5bdc2795f..a44d78f236 100644 --- a/gdb/testsuite/gdb.base/style.exp +++ b/gdb/testsuite/gdb.base/style.exp @@ -50,4 +50,8 @@ save_vars { env(TERM) } { gdb_test "" "\033\\\[35;1mGNU gdb.*\033\\\[m.*" \ "version is styled" + + set quoted [string_to_regexp $binfile] + gdb_test "file $binfile" \ + "Reading symbols from \033\\\[32m${quoted}\033\\\[m..." \ } -- 2.17.2