From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46627 invoked by alias); 21 Nov 2018 13:19:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46610 invoked by uid 89); 21 Nov 2018 13:19:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Gm-Message-State:aEWb, HX-Received:sk:93-v6mr, speedy, Hx-languages-length:1389 X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Nov 2018 13:19:04 +0000 Received: by mail-wr1-f66.google.com with SMTP id j10so5662663wru.4 for ; Wed, 21 Nov 2018 05:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BBfP6IHWoJQ58xiRMD3wSfN7ud0BWszetAIPMdCjBIs=; b=Q9I407hHXX4rOrTqIDvGRB/gUHRGhrfRD/zHdMJ5eXhxFPIxmLBsjlHVkRrds3H/q7 /vrRpIke4mJ/QxouFOvrCts187EVCgKB6xEl+AkdW1rTa9s7p9xg5owvyHW950Ns7vRb 8Ko2SubDdTFWKHKLBzAhH0qF1qNe83CBQjLXN3REd3yn3CGrhhgwdrfRmaEMtCa8hNBP FZ4kskAQMi4MYCGun9HT7q2wGcC24ek0g/YhdoIdwjzJGiXMe/BHRGn9hDJq7RTi8+8V lwAT9VNPFGYq/NXscWHtOhzWhXJF1PRlJYPiEkAWjA1dJ21ITYakWGFvi35khC041KvJ SyKQ== Return-Path: Received: from localhost (host81-156-111-139.range81-156.btcentralplus.com. [81.156.111.139]) by smtp.gmail.com with ESMTPSA id b18sm17628478wrw.83.2018.11.21.05.19.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Nov 2018 05:19:00 -0800 (PST) Date: Wed, 21 Nov 2018 13:19:00 -0000 From: Andrew Burgess To: gdb-patches@sourceware.org Cc: jimw@sifive.com, palmer@sifive.com, jhb@freebsd.org, Eli Zaretskii Subject: Re: [PATCH] gdb/riscv: Add target description support Message-ID: <20181121131858.GY16539@embecosm.com> References: <20181108160745.24600-1-andrew.burgess@embecosm.com> <20181114145756.GM16539@embecosm.com> <20181121112335.GX16539@embecosm.com> <83y39mhain.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83y39mhain.fsf@gnu.org> X-Fortune: You shall be rewarded for a dastardly deed. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00355.txt.bz2 * Eli Zaretskii [2018-11-21 14:37:20 +0200]: > > Date: Wed, 21 Nov 2018 11:23:35 +0000 > > From: Andrew Burgess > > Cc: gdb-patches@sourceware.org, Palmer Dabbelt , > > John Baldwin > > > > Eli, > > > > I believe I still need a doc review before I can merge this patch. > > Could I ask you to take a look please. > > Sorry, I thought I already did. See below. No problem, and thanks for the speedy review. I've pushed this patch with the fixes suggested by Eli. Thanks, Andrew > > > +The @samp{org.gnu.gdb.riscv.fpu} feature is optional. If present it > ^ > Please insert a comma where shown. > > > +should contain registers @samp{f0} through @samp{f31}, @samp{fflags}, > > +@samp{frm}, and @samp{fcsr}. As with the cpu feature either the > ^ > And here. > > > +The @samp{org.gnu.gdb.riscv.virtual} feature is optional. If present > ^ > And here. > > > +it should contain registers that are not backed by real registers on > > +the target but are instead virtual, where the register value is > ^ > And here. > > > +derived from other target state. In many ways these are like GDBs > ^^^^ > @value{GDBN}s > > > +The @samp{org.gnu.gdb.riscv.csr} feature is optional. If present it > ^ > Need a comma there. > > OK with these nits fixed. > > Thanks.