From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123398 invoked by alias); 20 Nov 2018 17:01:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123299 invoked by uid 89); 20 Nov 2018 17:01:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Kevin, rightly, Hx-languages-length:821 X-HELO: jocasta.intra Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Nov 2018 17:01:31 +0000 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id wAKH1PZx008832 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Nov 2018 18:01:25 +0100 Received: (from john@localhost) by jocasta.intra (8.15.2/8.15.2/Submit) id wAKH1P9o008831; Tue, 20 Nov 2018 18:01:25 +0100 Date: Tue, 20 Nov 2018 17:01:00 -0000 From: John Darrington To: Kevin Buettner Cc: gdb-patches@sourceware.org, John Darrington Subject: Re: [PATCH] GDB: S12Z: new function s12z_extract_return_value Message-ID: <20181120170124.hssaj76bdwcpfu6b@jocasta.intra> References: <20181117233550.09353eeb@pinnacle.lan> <20181120075626.5385-1-john@darrington.wattle.id.au> <20181120094031.731d359b@pinnacle.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181120094031.731d359b@pinnacle.lan> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-11/txt/msg00332.txt.bz2 On Tue, Nov 20, 2018 at 09:40:31AM -0700, Kevin Buettner wrote: On Tue, 20 Nov 2018 08:56:26 +0100 John Darrington wrote: > Make gdb aware of the return values of functions which > return in registers. > > gdb/ChangeLog: > * s12z-tdep.c (s12z_extract_return_value): New function. > (inv_reg_perm) New array. > (s12z_return_value): Populate readbuf if non-null. Okay. (But make sure that the leading spaces get changed to a single tab when you place your ChangeLog entry in the ChangeLog file.) Thanks. I will do that. (If I remember rightly however, the link you posted earlier explicitly stated that the leading whitespace should be 8 spaces. But as all other entries have used tabs it seems best to be consistent.) J'