From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112321 invoked by alias); 20 Nov 2018 05:16:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112312 invoked by uid 89); 20 Nov 2018 05:16:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Nov 2018 05:16:37 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8CA9416974A; Tue, 20 Nov 2018 05:16:36 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5EFC36012D; Tue, 20 Nov 2018 05:16:36 +0000 (UTC) Date: Tue, 20 Nov 2018 05:16:00 -0000 From: Kevin Buettner To: John Darrington Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] GDB: S12Z: Add assertion Message-ID: <20181119221634.6feec383@pinnacle.lan> In-Reply-To: <20181119164734.31022-1-john@darrington.wattle.id.au> References: <20181117145928.726522e6@pinnacle.lan> <20181119164734.31022-1-john@darrington.wattle.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00314.txt.bz2 Hi John, This is okay. Go ahead and push it. You leave the diff for ChangeLog out of your patches. Just make sure that the ChangeLog entries are placed at the top of the ChangeLog file with suitable header (date, name, and email) at the time that the change is pushed. Kevin On Mon, 19 Nov 2018 17:47:34 +0100 John Darrington wrote: > gdb/ChangeLog: > > * s12z-tdep.c (s12z_frame_cache): Add an assertion. > --- > gdb/ChangeLog | 8 ++++++++ > gdb/s12z-tdep.c | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 4fa0b42657..990cfc3f9d 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2018-11-19 John Darrington > + > + *s12z-tdep.c (s12z_frame_cache): Add an assertion. > + > 2018-11-18 Tom Tromey > > PR build/23814: > @@ -216,6 +220,10 @@ > frame cache, leave the frame id as the default, which is the outer > frame id. > > +2018-11-14 John Darrington > + > + * s12z-tdep.c (s12z_frame_cache): Add an assertion. > + > 2018-11-07 Joel Brobecker > > * ada-lang.c (read_atcb): Only set task_info->called_task if > diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c > index 79f5772035..bd0bd7c001 100644 > --- a/gdb/s12z-tdep.c > +++ b/gdb/s12z-tdep.c > @@ -320,6 +320,7 @@ s12z_frame_cache (struct frame_info *this_frame, void **prologue_cache) > } > else > { > + gdb_assert (this_sp == this_sp_for_id); > /* The stack pointer of the prev frame is frame_size greater > than the stack pointer of this frame plus one address > size (caused by the JSR or BSR). */ > -- > 2.11.0 >