From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95428 invoked by alias); 17 Nov 2018 21:59:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95416 invoked by uid 89); 17 Nov 2018 21:59:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1106, prev, HCc:D*au X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 17 Nov 2018 21:59:30 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2F06308FB90; Sat, 17 Nov 2018 21:59:29 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56CD760BF1; Sat, 17 Nov 2018 21:59:29 +0000 (UTC) Date: Sat, 17 Nov 2018 21:59:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: John Darrington Subject: Re: [PATCH 1/2] GDB: S12Z: Add assertion Message-ID: <20181117145928.726522e6@pinnacle.lan> In-Reply-To: <20181112091721.28040-1-john@darrington.wattle.id.au> References: <20181112091721.28040-1-john@darrington.wattle.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00272.txt.bz2 On Mon, 12 Nov 2018 10:17:20 +0100 John Darrington wrote: > --- > gdb/s12z-tdep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c > index 79f5772035..bd0bd7c001 100644 > --- a/gdb/s12z-tdep.c > +++ b/gdb/s12z-tdep.c > @@ -320,6 +320,7 @@ s12z_frame_cache (struct frame_info *this_frame, void **prologue_cache) > } > else > { > + gdb_assert (this_sp == this_sp_for_id); > /* The stack pointer of the prev frame is frame_size greater > than the stack pointer of this frame plus one address > size (caused by the JSR or BSR). */ > -- Could you please add a ChangeLog entry? Also, on the same topic, what happened to the ChangeLog entries for the initial commit / push of the s12z port? (I don't see them in the ChangeLog file.) As for adding the assert, I suppose that you're just reminding the reader of this earlier assignment? ... this_sp_for_id = this_sp; (I didn't see anything which might change either this_sp or this_sp_for_id along the code path leading to the assert.) Kevin