From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44406 invoked by alias); 13 Nov 2018 15:05:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44284 invoked by uid 89); 13 Nov 2018 15:05:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1804, market X-HELO: mail-wm1-f41.google.com Received: from mail-wm1-f41.google.com (HELO mail-wm1-f41.google.com) (209.85.128.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Nov 2018 15:04:59 +0000 Received: by mail-wm1-f41.google.com with SMTP id t15-v6so11788613wmt.0 for ; Tue, 13 Nov 2018 07:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=au+smbf0bEAJAag9qFt6FmgcTETjhLvcSqR+eiUwpwQ=; b=WuYszGyxeK7E3QnS5sM+T4qpda/RUCsRbQSEsn0k7SOocDFM31qDrvc0bLR07l6FFI j9x+l15mI9T5UVSV+8xRkTaD0hz1/QM2VZA7pcVHJCnynbJH5i7M8NBVdUfLM9J5fDlD GeAjvmrDTpaSkdF8utSWhJZBPdSr6nEZ6Vd4KZMvu1LrAl9F0c/T+/sPyh9Idqljwd7S sLqGqlW0S4OTtC6/snwjXRuvZ+0nOsWVEV4n7iPfLsL+HlbwxvGMAc5Et8pzVQIxYmfz aV7QxpfiYHoVr33AxgidvVDDClgx/sm+m+lKYvjQMYDaXc+nMwqgFM46TIUqeL/spSqr Yj/g== Return-Path: Received: from localhost (host81-148-252-35.range81-148.btcentralplus.com. [81.148.252.35]) by smtp.gmail.com with ESMTPSA id b66-v6sm10915766wmb.21.2018.11.13.07.04.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Nov 2018 07:04:56 -0800 (PST) Date: Tue, 13 Nov 2018 15:05:00 -0000 From: Andrew Burgess To: Jim Wilson Cc: gdb-patches@sourceware.org, Palmer Dabbelt , John Baldwin Subject: Re: [RFC] gdb/riscv: Add target description support Message-ID: <20181113150455.GK16539@embecosm.com> References: <20181108160745.24600-1-andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: Don't get stuck in a closet -- wear yourself out. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00219.txt.bz2 * Jim Wilson [2018-11-08 13:57:10 -0800]: > On Thu, Nov 8, 2018 at 8:07 AM Andrew Burgess > wrote: > > riscv*-*-linux*) > > # Target: Linux/RISC-V > > - gdb_target_obs="riscv-linux-tdep.o riscv-tdep.o glibc-tdep.o \ > > + gdb_target_obs="riscv-linux-tdep.oglibc-tdep.o \ > > linux-tdep.o solib-svr4.o symfile-mem.o linux-record.o" > > There is a typo here, a space is missing between riscv-linux-tdep.o > and glibc-tdep.o. Good spot. I'll fix this. > > Otherwise this looks great. I tested it on riscv64-linux and saw no > new problems. I also tested with riscv-tests/debug against openocd, > and almost everything that failed before is now passing. There are > two tests that fail because riscv-tests/debug doesn't know how to > parse the new {float...double...} string output for FP registers. > There are two tests that fail for a 32-bit target with > (gdb) p/x fox = "This little piggy went to the market." > p/x fox = "This little piggy went to the market."^M > /scratch/jimw/openocd/fsf-gdb/riscv-gnu-toolchain/build/../riscv-gdb/gdb/regcac\ > he.c:298: internal-error: void > regcache::restore(readonly_detached_regcache*): \ > Assertion `src != NULL' failed.^M I have a fix for this issue, but it's not really related to target register descriptions. I hope to get this posted soon. > And the same tests fail for a 64-bit target with a timeout. That may > only be one problem. This should not prevent the XML register set > support from going in now, and we can worry about debugging these > problems later. Even with the failures this is a major improvement > over what we had before. Great. I just need to review John's feedback and then we can move this forward. Thanks again, Andrew