From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127021 invoked by alias); 31 Oct 2018 21:27:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127012 invoked by uid 89); 31 Oct 2018 21:27:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 21:27:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D0AD85605C; Wed, 31 Oct 2018 17:27:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cqx9P6Dotdua; Wed, 31 Oct 2018 17:27:02 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7EA0056020; Wed, 31 Oct 2018 17:27:02 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 708BA83AF5; Wed, 31 Oct 2018 14:27:00 -0700 (PDT) Date: Wed, 31 Oct 2018 21:27:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Simon Marchi , GDB Patches Subject: Re: [PATCH] Fix PR gdb/23835: Don't redefine _FORTIFY_SOURCE if it's already defined Message-ID: <20181031212700.GC4081@adacore.com> References: <20181030214236.29081-1-sergiodj@redhat.com> <7524d20b4c0390d73fcd4225924329df@polymtl.ca> <20181030224717.GA4081@adacore.com> <87va5h990c.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87va5h990c.fsf@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-10/txt/msg00765.txt.bz2 > Thanks for the review, Joel. > > Given that two global maintainers replied and approved the patch, I > assume it's OK if I go ahead and push it...? Yes, sorry. That was part of the intent of my message; it's a small patch anyway, so if we find there are problems with it, or objections we can't resolve quickly, it's easy to revert. -- Joel